fix return none when bool expected

opengento · Feb 26, 2021 · dd4200b · dd4200b
1 parent 8df6c2c
commit dd4200b
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/Model/Document/Helper/File.php b/Model/Document/Helper/File.php
@@ -115,14 +115,12 @@ public function deleteFile(string $filePath): bool
     {
         try {
             $directoryWrite = $this->filesystem->getDirectoryWrite(DirectoryList::MEDIA);
-            if ($filePath && $directoryWrite->isFile($filePath)) {
-                return $directoryWrite->delete($filePath);
-            }
+            return $filePath && $directoryWrite->isFile($filePath) && $directoryWrite->delete($filePath);
         } catch (FileSystemException $e) {
             $this->logger->error($e->getLogMessage(), $e->getTrace());
-
-            return false;
         }
+
+        return false;
     }
 
     private function resolveFileSubPath(DocumentTypeInterface $documentType, string $fileName): string