Generate deltas no matter the vector QFS layer action

[suricactus]

Removed QFieldCloudUtils::isCloudAction as an obsolete method

@m-kuhn for testing

[qfield-fairy]

🎉 Ta-daaa, freshly created APKs are available for 6c70b25: arm64-android

Other architectures

• arm-neon-android
• x64-android
• x86-android
• all access arm64-android
• all access arm-neon-android
• all access x64-android
• all access x86-android

[nirvn]

@suricactus , my comment was actually wrong, the code was bailing out in addLayerListeners() if the project wasn't a cloud one. I got confused as the cloud project check happens earlier when we handle the QgsProject::onHomePathChanged. I've moved the cloud check to occur in LayerObserver::onLayersAdded to mimic what we do in LayerObserver::onHomePathChanged.

I think this is ready to merge.

[nirvn]

@suricactus , @m-kuhn , can we merge this?

[m-kuhn]

Several people mentioned bad results (empty deltas) with this. Please hold back.

[nirvn]

@m-kuhn , roger that.

[nirvn]

@m-kuhn , you beat me to it, was closing/re-opening to catch latest CI naming changes :)

[suricactus]

Several people mentioned bad results (empty deltas) with this. Please hold back.

@m-kuhn Do you have steps to reproduce?

[m-kuhn]

@SeqLaz and @lucienicolier should know more

[nirvn]

@suricactus , should we close this PR or is it still relevant?

[suricactus]

Will close the PR, but there is still work to be done here.