Safeguard from triggering needless feature gathering when referincing feature list model gets passed the same feature #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature list model gets passed the same feature
|
🎉 Ta-daaa, freshly created APKs are available for 489f4d3: arm64-android |
m-kuhn
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our referencing feature list model was needlessly triggering (possibly costly) features fetches when the referencing feature property was set with the exact same feature (which does happen when QML builds our feature form item). This offers yet another nice optimization for our feature form.
This PR also fixes #3031 . It doesn't fix the root cause of it (it freezes in the OGR connection pool, stuck in a loop evaluating expressions et al), but by axing the number of feature fetches by half, the connection pool never gets saturated.