-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of basic image attachment sketching capability #5149
Conversation
🎉 Ta-daaa, freshly created APKs are available for de24f0c: arm64-android |
93afc61
to
d05b118
Compare
Esto se podría usar a futuro para recopilar firmas digitales... |
31b6eb5
to
3a4eec5
Compare
a26ecb2
to
9d269ff
Compare
…le against white or black background
… menu, add drawing item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 26. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks generally good to me. Just the two issues i found out by testing:
- Buttons to small to hit
- Feature form tabs reacting strange
Alright let's merge and deal with those lingering issues in separate PRs. |
This PR implements an in-house drawing/sketching functionality to QField, and exposes it in the attachment widget allowing for users to quickly sketch over images they have taken.
Video showing UI to add a new drawing (blank or based on template) as attachment:
Screencast.from.2024-03-29.17-43-43.webm
Video showing UI/UX to draw over pre-existing image attachment:
Screencast.from.2024-03-28.14-06-47.webm
The UI is minimalist in nature and aims at being light while offering basic functionalities needed. Follow up PRs will cover sketch background templates and more UI changes to expose e.g. sketching from scratch attachment.