Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a QFieldCloud server combobox to ease multi-server environments #5607

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Sep 4, 2024

Looks:

image

This added combobox functionality makes it much easier to switch back and forth from the default QFieldCloud server (https://apps.qfield.cloud) and custom server(s). No need to remember the exact URL, just pick it from the history of URLs 🥳

This also aligns QField to QFieldSync where we've had a combobox for a long time:

image

@qfield-fairy
Copy link
Collaborator

@suricactus
Copy link
Collaborator

suricactus commented Sep 4, 2024

Two questions:

  • how does one delete a URL
  • how does one get an ordered list of URLs

Nice change anyway, but without the ability to prune the list I think it is dangerous.

@nirvn
Copy link
Member Author

nirvn commented Sep 4, 2024

@suricactus , the list of URLs == a saved list of URLs successfully connected to; by default there's only the defaultUrl() in there.

On the security front, ATM the last connected URL always shows, so we're adding exposure to a URL string (not credentials) if the person connects to a 3rd party URL then goes back to the app.qfield.cloud server. Otherwise things essentially stay the same.

@suricactus
Copy link
Collaborator

suricactus commented Sep 4, 2024

@suricactus , the list of URLs == a saved list of URLs successfully connected to; by default there's only the defaultUrl() in there.

On the security front, ATM the last connected URL always shows, so we're adding exposure to a URL string (not credentials) if the person connects to a 3rd party URL then goes back to the app.qfield.cloud server. Otherwise things essentially stay the same.

Hey, sorry, I meant the order of the list. If I read the code correctly, it only appends in the end. Would be better if we sort alphabetically OR we have the most recent on top.

It is more that I work for OPENGIS.ch GmbH and I was connecting to cloud.opengis.ch. Then I leave the company and join QFieldCloud GmbH and I need to connect to cloud.qfield.cloud for my daily work. I don't want to see cloud.opengis.ch anymore.

@nirvn
Copy link
Member Author

nirvn commented Sep 4, 2024

@suricactus , ah -- I kind of like having the default URL as the first choice, but we can order alphabetically too.

@nirvn
Copy link
Member Author

nirvn commented Sep 5, 2024

@suricactus , with regards to deleting URLs, ATM it's not possible (other than by wiping the user profile storage). Would you be OK to merge this as is and address these issues in follow up PRs?

@suricactus
Copy link
Collaborator

Sure, if the follow-up is planned soonish, go ahead!

@nirvn nirvn merged commit 080dc0b into master Sep 5, 2024
22 of 23 checks passed
@nirvn nirvn deleted the cloud_server_combobox branch September 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants