Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip comment when CI not running from opengisch repository #5627

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Sep 8, 2024

Less red.

@m-kuhn
Copy link
Member

m-kuhn commented Sep 8, 2024

We might want to do what QGIS does for this, it's not yet as flexible and portable as I'd like it to be, with a bit of luck I get around to implementing something better.

@nirvn
Copy link
Member Author

nirvn commented Sep 9, 2024

@m-kuhn , probably still worth turning red into green for the immediate future, then eventually replace.

The PR also includes additional fixes to shut down daily action failures (cron jobs) on 3rd party repositories. IMHO pretty important as it otherwise means anybody forking QField ATM gets notification spammed :)

@m-kuhn
Copy link
Member

m-kuhn commented Sep 9, 2024

@m-kuhn , probably still worth turning red into green for the immediate future, then eventually replace.

👍

The PR also includes additional fixes to shut down daily action failures (cron jobs) on 3rd party repositories. IMHO pretty important as it otherwise means anybody forking QField ATM gets notification spammed :)

I was under the impression, that 3rd party repos need to opt in to enable workflows on forks, but if you say so

@nirvn nirvn merged commit cf8db60 into opengisch:master Sep 9, 2024
22 of 23 checks passed
@nirvn
Copy link
Member Author

nirvn commented Sep 9, 2024

@m-kuhn , maybe it's because of my user status within the main repo? In any case, I didn't enable anything and I got a bunch of daily notifications after pulling my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants