Skip to content

Commit

Permalink
fix view_schema when creating single inheritance from multiple defini…
Browse files Browse the repository at this point in the history
…tion
  • Loading branch information
3nids committed Oct 25, 2023
1 parent 50e1464 commit 889156d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion pirogue/multiple_inheritance.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ def create(self) -> bool:
success &= SingleInheritance(pg_service=self.pg_service,
parent_table='{s}.{t}'.format(s=self.master_schema, t=self.master_table),
child_table='{s}.{t}'.format(s=table_def['table_schema'], t=table_def['table_name']),
view_name='vw_{a}'.format(a=alias)
view_name='vw_{a}'.format(a=alias),
view_schema=self.view_schema,
).create()
return success

Expand Down
2 changes: 1 addition & 1 deletion pirogue/simple_joins.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def __init__(self,

# check definition validity
for key in definition.keys():
if key not in ('table', 'view_schema','joins', 'pkey', 'view_name'):
if key not in ('table', 'view_schema', 'joins', 'pkey', 'view_name'):
raise InvalidDefinition('key {k} is not a valid'.format(k=key))
# check joins validity
for alias, table_def in definition['joins'].items():
Expand Down

0 comments on commit 889156d

Please sign in to comment.