Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding validator for files on converter to cloud project #614

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Sep 21, 2024

No description provided.

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add such function in file utils.

Also the pattern is a bit more complex, expecially for windows. Can we use something like this:

\A(?!(?:COM[0-9]|CON|LPT[0-9]|NUL|PRN|AUX|com[0-9]|con|lpt[0-9]|nul|prn|aux)|\s|[\.]{2,})[^\\\/:*"?<>|]{1,254}(?<![\s\.])\z

Even better, we can check if pathvalidate is installed and use that, otherwise fallback to the above regex (or better one). Don't forget to check if the file path is also correct.

@SeqLaz
Copy link
Member Author

SeqLaz commented Sep 23, 2024

I would add such function in file utils.

Also the pattern is a bit more complex, expecially for windows. Can we use something like this:

\A(?!(?:COM[0-9]|CON|LPT[0-9]|NUL|PRN|AUX|com[0-9]|con|lpt[0-9]|nul|prn|aux)|\s|[\.]{2,})[^\\\/:*"?<>|]{1,254}(?<![\s\.])\z

Even better, we can check if pathvalidate is installed and use that, otherwise fallback to the above regex (or better one). Don't forget to check if the file path is also correct.

Thank you. Due to the library pathvalidate not being installed, I used your regex for the validations and moved the function to /utils/file_utils.py.

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the ProjectChecker for providing this kind of feedback? There is already ASCII filename warnings, the file one to be added should be an error that prevents further actions with the project.

@SeqLaz
Copy link
Member Author

SeqLaz commented Oct 4, 2024

ProjectChecker

Can we use the ProjectChecker for providing this kind of feedback? There is already ASCII filename warnings, the file one to be added should be an error that prevents further actions with the project.

For this it will be require to add a method to libqfieldsync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants