Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to create a service file at a default location #32

Merged
merged 2 commits into from
May 17, 2024

Conversation

gacarrillor
Copy link
Contributor

@gacarrillor gacarrillor commented May 16, 2024

Useful to help them to get started with the plugin if no service file is found when opening the dialog.

vokoscreenNG-2024-05-16_15-28-32.mp4

Fix #27

…fault location if it's not found when the dialog is opened
@gacarrillor
Copy link
Contributor Author

Note this PR points to https://github.com/opengisch/qgis-pg-service-parser-plugin/tree/add_remove_service_settings branch.
When we consider the current PR ready, I'd suggest that we merge it before merging PR #31 to master.

@3nids
Copy link
Member

3nids commented May 17, 2024

Awesome!

Do you know why highlighting when modified doesn't work in the demo?

@gacarrillor
Copy link
Contributor Author

Awesome!

Do you know why highlighting when modified doesn't work in the demo?

Host/port/dbname are actually stored in the newly created file, as a 'template'. That's why they don't appear in green.
If this can lead to some confusion, I can try to add them as if they were being edited instead.

@gacarrillor
Copy link
Contributor Author

gacarrillor commented May 17, 2024

Do you know why highlighting when modified doesn't work in the demo?

Much better indeed! Thanks for the suggestion!

image

@gacarrillor gacarrillor merged commit af73d1e into add_remove_service_settings May 17, 2024
2 checks passed
@gacarrillor gacarrillor deleted the create_file branch May 17, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants