Skip to content

Commit

Permalink
fix missing return
Browse files Browse the repository at this point in the history
  • Loading branch information
why-not-try-calmer committed Oct 4, 2023
1 parent 3f01fc6 commit 6c48654
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions qgispluginci/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def validate_args(args: Namespace):
patterns = Parameters.get_release_version_patterns()
semvar_compliance = re.match(patterns.pop("semver"), args.release_version)

if semvar_compliance is None:
if not semvar_compliance:
logging.warning(
f"Be aware that '{args.release_version}' is not a semver-compliant version."
)
Expand All @@ -263,9 +263,11 @@ def validate_args(args: Namespace):
re.match(other_pattern, args.release_version)
for other_pattern in patterns.values()
):
raise ValueError(
f"Unable to validate the release version '{args.release_version}'. You can disable validation by running this command again with an extra '--no-validation' flag. Otherwise please use a release version identifier in the shape of 'v1.1.1', 'v1.1', '1.0.1', '1.1'. Version semantic (semvar) identifiers are recommended. Take a look at https://en.wikipedia.org/wiki/Software_versioning#Semantic_versioning for a refresher."
)
return

raise ValueError(
f"Unable to validate the release version '{args.release_version}'. You can disable validation by running this command again with an extra '--no-validation' flag. Otherwise please use a release version identifier in the shape of 'v1.1.1', 'v1.1', '1.0.1', '1.1'. Version semantic (semvar) identifiers are recommended. Take a look at https://en.wikipedia.org/wiki/Software_versioning#Semantic_versioning for a refresher."
)

@staticmethod
def archive_name(
Expand Down

0 comments on commit 6c48654

Please sign in to comment.