MinGW and MacOS Fixes #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`glext.h` does not need to be included on MacOS, so it is only included if the OS is not Apple. The Cocoa, IOkit, CoreFoundation, and CoreVideo frameworks are needed in order to compile and link glfw3. This has been added to the `CMakeLists.txt` file if configuring on Apple.
The code and CMake setup for GLFW 3.2 has big improvements over 3.0, so it is added as an additional external dependency.
MinGW does not come with OpenMP, so those examples are commented out for the time being. When using MinGW, the `Sleep()` function results in an unresolved symbol when linking. These function calls are skipped when the `__MINGW32__` symbol is defined. Add instructions how to properly request C++11 and use of the `M_PI` macro when using MinGW.
`sin()` by default operates on double in C. The original code casts the result to `float`. This is slow and loses precision unnecessarily. Rather than use `sinf()`, since the code is C++, it is better to cast `currentTime` to `float` (using a `static_cast`) once and then use std::sin(), which is overloaded for `float`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demos now compile with CodeBlocks/MinGW using the regular CMake process.
For now, I've omitted OpenMP-dependent executables, but that can easily be fixed using CMake's
FindOpenMP module.
Had to make some minor tweaks because
Sleep()would result in unresolved symbols.Also added compile instructions to set MinGW to C++11 and how to properly enable the
M_PImacro.I've added GLFW3 3.2.1 as an external dependency as that seems to fix a lot of problems on MacOS.
I've also added appropriate
gitattributesandgitignorefiles to ensure proper line endingconversions.