Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the email input box for encrypt form modal #8071

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

g-tejas
Copy link
Contributor

@g-tejas g-tejas commented Jan 23, 2025

Problem

https://www.notion.so/opengov/Allow-inputting-email-recipients-on-form-creation-13777dbba78880619402dd8d48ab7209

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Before After
Screenshot 2025-01-23 at 2 49 26 PM Screenshot 2025-01-23 at 2 50 47 PM

Tests

Encrypt forms

  • 1. Create encrypt mode form
  • 2. Observe that the admin email is inserted by default
  • 3. Observe that the email input field is optional, you're allowed to remove it and leave it empty
  • 4. Add your email, and create the form. Navigate to the email settings page
  • 5. Observe that the email inputted earlier exists (or empty if not included earlier)

Duplicated forms

  • 1. Create an email mode form, with the admin email inside.
  • 2. Duplicate that form to encrypt mode
  • 3. Observe that the email input is present, and is optional
  • 4. Observe that the emails are carried over from the duplicated form.

@g-tejas g-tejas requested a review from a team January 23, 2025 06:53
@g-tejas g-tejas marked this pull request as draft January 23, 2025 06:54
@g-tejas g-tejas force-pushed the feat/encrypt-mode-input-modal branch from 2971ba0 to 82e77a7 Compare January 24, 2025 07:56
@g-tejas g-tejas self-assigned this Jan 24, 2025
@g-tejas g-tejas deployed to staging-alt January 24, 2025 08:26 — with GitHub Actions Active
@g-tejas g-tejas marked this pull request as ready for review January 27, 2025 06:34
@g-tejas g-tejas marked this pull request as draft January 27, 2025 06:38
@g-tejas g-tejas marked this pull request as ready for review January 27, 2025 07:54
@g-tejas g-tejas requested a review from KenLSM January 27, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant