Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url redirect passing in url into description bug #8090

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

scottheng96
Copy link
Contributor

@scottheng96 scottheng96 commented Feb 11, 2025

Problem

Upon 'Learn More' button click under 'Enable Retries' section, url does not redirect to webhooks guide.

image

Solution

explicitly label toggle inputs instead of passing it as a an object. FYI
{ returnObjects: true }, the t function returns the entire object for retry, not just the strings for label and description.

Breaking Changes

  • No - this PR is backwards compatible

Bug Fixes:
(upon re-direct, see below for behaviour - tested on local)

@scottheng96 scottheng96 requested a review from a team as a code owner February 11, 2025 09:04
@scottheng96
Copy link
Contributor Author

Screen.Recording.2025-02-11.at.3.29.17.PM.mov

Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KenLSM KenLSM changed the title fix: fix url redirect passing in url into description bug fix: url redirect passing in url into description bug Feb 12, 2025
@KenLSM KenLSM merged commit 0ccbef7 into develop Feb 12, 2025
28 checks passed
@KenLSM KenLSM deleted the fix/retry-url-redirect branch February 12, 2025 02:13
@scottheng96 scottheng96 mentioned this pull request Feb 12, 2025
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants