Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use portal by default in avatar menu #766

Closed
wants to merge 1 commit into from

Conversation

oliverchanyw
Copy link
Contributor

Problem

Bright uses the AvatarMenu in the app NavBar, which is a fairly typical use case. It is as sticky bar, which creates its own stacking context. Unrelated ancestor props like maxHeight or overflow then cause issues for the AvatarMenu.

Solution

There's rarely a reason not to use Menu with Portal. This changes AvatarMenu to do that, without changing the component signature.

Alternative considered

Accept a new custom prop like withPortal. Rejected because it is custom, and it feels acceptable to deny users the option to not use portal.

@oliverchanyw
Copy link
Contributor Author

hm why is the portal flaking the menu :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant