Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): temporarily disable dd test visibility for unit tests #706

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Sep 30, 2024

import-in-the-middle v1.11.0 release broke datadog's vitest test visibility tracing.

This PR temporarily disables the visibility harness for unit tests (playwright not affected) until it's fixed.

Related:

Solution

This change disables the Datadog Test Visibility configuration and tracing in the CI workflow for the isomer-studio project.

Breaking Changes

  • No - this PR is backwards compatible

Improvements:

  • Removed Datadog Test Visibility configuration step from the CI workflow
  • Commented out Datadog-related environment variables for the test run

Tests

No new tests are required for this change. Existing tests should continue to run without Datadog tracing.

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 3:21am

Copy link
Contributor Author

karrui commented Sep 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui marked this pull request as ready for review September 30, 2024 03:19
@karrui karrui requested a review from a team as a code owner September 30, 2024 03:19
@karrui karrui merged commit 78436b8 into main Sep 30, 2024
17 checks passed
@karrui karrui deleted the 09-30-fix_ci_temporarily_disable_dd_test_visibility_for_unit_tests branch September 30, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants