[surepetcare] Add support for waterstation Felaqua #18114
Conversation
* Fixes: openhab#15654 * added Felaqua pet waterstation * added UoM where possible * other small fixes Signed-off-by: Holger Eisold <[email protected]>
|
if someone wants to test on a 4.3.x install.. please let me know if there are any issues |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/new-sure-petcare-binding-for-cat-pet-flap/82257/91 |
| @@ -122,4 +124,7 @@ public class SurePetcareConstants { | |||
| public static final String PET_CHANNEL_FEEDER_LAST_CHANGE = "feederLastChange"; | |||
| public static final String PET_CHANNEL_FEEDER_LAST_CHANGE_LEFT = "feederLastChangeLeft"; | |||
| public static final String PET_CHANNEL_FEEDER_LAST_CHANGE_RIGHT = "feederLastChangeRight"; | |||
| public static final String PET_CHANNEL_WATER_DEVICE = "waterDevice"; | |||
| public static final String PET_CHANNEL_WATER_LASTDRINKING = "waterLastDrinking"; | |||
There was a problem hiding this comment.
| public static final String PET_CHANNEL_WATER_LASTDRINKING = "waterLastDrinking"; | |
| public static final String PET_CHANNEL_WATER_LAST_DRINKING = "waterLastDrinking"; |
| <property name="productType"/> | ||
| <property name="productName"/> | ||
| <property name="pairingAt"/> | ||
| <property name="thingTypeVersion">1</property> |
| <thing-type uid="surepetcare:waterDevice"> | ||
| <instruction-set targetVersion="1"> | ||
| <update-channel id="deviceRSSI"> | ||
| <type>surepetcare:rssiDeviceType</type> | ||
| </update-channel> | ||
| <update-channel id="hubRSSI"> | ||
| <type>surepetcare:rssiHubType</type> | ||
| </update-channel> | ||
| </instruction-set> | ||
| </thing-type> | ||
|
|
There was a problem hiding this comment.
Since the thing type waterDevice is introduced with this PR, no update instructions are needed.
| <thing-type uid="surepetcare:waterDevice"> | |
| <instruction-set targetVersion="1"> | |
| <update-channel id="deviceRSSI"> | |
| <type>surepetcare:rssiDeviceType</type> | |
| </update-channel> | |
| <update-channel id="hubRSSI"> | |
| <type>surepetcare:rssiHubType</type> | |
| </update-channel> | |
| </instruction-set> | |
| </thing-type> |
However, for thing type pet you have introduced three new channels, and they need to be added by update instructions.
There was a problem hiding this comment.
Please revert changes in this file. Translations should be provided through Crowdin after the PR is merged. See https://www.openhab.org/docs/developer/utils/i18n.html#managing-translations
| @@ -175,6 +177,8 @@ protected void updateThing() { | |||
| new StringType(device.control.lid.closeDelayId.toString())); | |||
| updateState(DEVICE_CHANNEL_BOWLS_TRAINING_MODE, | |||
| new StringType(device.control.trainingModeId.toString())); | |||
| } else if (thing.getThingTypeUID().equals(THING_TYPE_WATER_DEVICE)) { | |||
| // TODO | |||
| Thing pet 12345 "My Cat" @ "SurePetcare Pets" | ||
| } | ||
| ``` | ||
|
|
||
| ### Items configuration | ||
|
|
||
| <details> | ||
| <summary>New Items with Points (semantic model)</summary> |
There was a problem hiding this comment.
I don't think there is any reason to keep the "old" version if the only difference is that tags are added, and the example is extended?
|
|
||
| // Equipment representing thing: | ||
| // surepetcare:household:api:CHANGE_ME | ||
| // (SurePetcare Haushalt EddyMurphy) |
There was a problem hiding this comment.
The example should be in English - please check all item names, labels etc.
| Thing pet 12345 "My Cat" @ "SurePetcare Pets" | ||
| } | ||
| ``` | ||
|
|
||
| ### Items configuration | ||
|
|
||
| <details> |
There was a problem hiding this comment.
I'm not sure if this will work, but we can give it a try. Did you see other binding README's use this?
jlaur
changed the title
Signed-off-by: Holger Eisold [email protected]