[pythonscripting][wip] initial release #18229
Conversation
Working with "info is null" Working - occasional "info" is null
Graal engine working - occasional "info" is null
Working with "info is null" Working - occasional "info" is null
added "py" extension in getExtension First pass at mirroring jsscripting Created own GraalPythonScriptEngine based on the GraalJSScriptEngine Working - with exception of regex language updated working/lib directories to find modules in lib folder added python standard libraries Working version
Signed-off-by: Holger Hees <[email protected]>
added "py" extension to getExtension in factory
Signed-off-by: Holger Hees <[email protected]>
Added injection of scope hashmap
inserted scope variables from the scopeValues method in the component
… - not needed since one is created in OpenhabGraalPythonScriptEngine cleanup
Eliminate creating a default engine in GraalPythonScriptEngineFactory…
|
python import wrapper is implemented and python code is moved to https://github.com/HolgerHees/openhab-python . This could be converted to a openhab repo later. |
There was a problem hiding this comment.
Thanks for adding another automation, that's awesome! While you await a review and still are working on this, you could have a look also at compiler and checkstyle warnings. See target/code-analysis/report.html.
I have added a few quick minor comments, but only scratching the surface while peeking.
...ipting/src/main/java/org/openhab/automation/pythonscripting/internal/PythonScriptEngine.java
Outdated
Show resolved
Hide resolved
...ipting/src/main/java/org/openhab/automation/pythonscripting/internal/PythonScriptEngine.java
Outdated
Show resolved
Hide resolved
...ipting/src/main/java/org/openhab/automation/pythonscripting/internal/PythonScriptEngine.java
Outdated
Show resolved
Hide resolved
...ipting/src/main/java/org/openhab/automation/pythonscripting/internal/PythonScriptEngine.java
Outdated
Show resolved
Hide resolved
...ipting/src/main/java/org/openhab/automation/pythonscripting/internal/PythonScriptEngine.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/automation/pythonscripting/internal/graal/GraalPythonScriptEngine.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/automation/pythonscripting/internal/graal/GraalPythonScriptEngine.java
Outdated
Show resolved
Hide resolved
...a/org/openhab/automation/pythonscripting/internal/wrapper/ScriptExtensionModuleProvider.java
Outdated
Show resolved
Hide resolved
...a/org/openhab/automation/pythonscripting/internal/wrapper/ScriptExtensionModuleProvider.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.automation.pythonscripting/src/main/resources/OH-INF/addon/addon.xml
Outdated
Show resolved
Hide resolved
thanks for the valuable feedback. I fixed all places related to your commends. Most things are leftovers where I was not sure if it is really needed. Now, I checked these places again and refactored or cleaned it. Also most of the hints from code analysis is fixed. Except 7 places with the recommendation to set "NonNullByDefault" to classes. Most of theses classes extending other classes which makes it difficult. |
...src/main/java/org/openhab/automation/pythonscripting/internal/graal/GraalPythonBindings.java
Outdated
Show resolved
Hide resolved
Initial release with detailed description in marketplace
https://community.openhab.org/t/python3-scripting/161945
and it has still one major known issues #18054 (comment)
in the final version, before I merge, I will rebase the project to clean the history.