Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keba] Implement thing action to set display text #18310

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maihacke
Copy link
Contributor

This PR is related to the suggestion in #18025.
It implements a new thing action for the keba binding which allows to set the display text:

rule "Set Display Text"
when
  System reached start level 100
then
   val keContactActions = getActions("keba", "keba:kecontact:1")
   // Default duration
   keContactActions.setDisplay("TEXT$1")
   // Explicit duration set
   keContactActions.setDisplay("TEXT$2", 5, 10)
end

Regarding QS I created a version for 4.x and tested it. Works quite well. There are now code changes in 5.x, and in the end it uses the existing infrastructure of the binding to set the display text. So assume it will work in 5.x also.

@maihacke maihacke requested a review from kgoderis as a code owner February 21, 2025 21:03
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Feb 24, 2025
Signed-off-by: Simon Spielmann <[email protected]>
Signed-off-by: Simon Spielmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants