Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daikin] Add semantic tags to channels #18315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[daikin] Add semantic tags to channels #18315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions bundles/org.openhab.binding.daikin/src/main/resources/OH-INF/i18n/daikin.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,13 @@ channel-type.daikin.acunit-homekitmode.state.option.cool = Cooling On
channel-type.daikin.acunit-homekitmode.state.option.off = Off
channel-type.daikin.acunit-humidity.label = Indoor Humidity
channel-type.daikin.acunit-humidity.description = The indoor humidity as measured by the A/C unit
channel-type.daikin.acunit-indoortemp.label = Indoor Temperature
channel-type.daikin.acunit-indoortemp.description = The indoor temperature
channel-type.daikin.acunit-mode.label = Mode
channel-type.daikin.acunit-mode.description = Current mode of the AC unit
channel-type.daikin.acunit-mode.state.option.AUTO = auto
channel-type.daikin.acunit-mode.state.option.DEHUMIDIFIER = dehumidifier
channel-type.daikin.acunit-mode.state.option.COLD = cooling
channel-type.daikin.acunit-mode.state.option.HEAT = heating
channel-type.daikin.acunit-mode.state.option.FAN = fan
channel-type.daikin.acunit-outdoortemp.label = Outdoor Temperature
channel-type.daikin.acunit-outdoortemp.description = The outdoor temperature
channel-type.daikin.acunit-power.label = Power
channel-type.daikin.acunit-power.description = Power for the AC unit
channel-type.daikin.acunit-settemp.label = Set Point
Expand Down
81 changes: 60 additions & 21 deletions bundles/org.openhab.binding.daikin/src/main/resources/OH-INF/thing/thing-types.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
<channels>
<channel id="power" typeId="acunit-power"/>
<channel id="settemp" typeId="acunit-settemp"/>
<channel id="indoortemp" typeId="acunit-indoortemp"/>
<channel id="outdoortemp" typeId="acunit-outdoortemp"/>
<channel id="indoortemp" typeId="system.indoor-temperature"/>
<channel id="outdoortemp" typeId="system.outdoor-temperature"/>
<channel id="humidity" typeId="acunit-humidity"/>
<channel id="mode" typeId="acunit-mode"/>
<channel id="homekitmode" typeId="acunit-homekitmode"/>
Expand Down Expand Up @@ -57,7 +57,7 @@
</channels>

<properties>
<property name="thingTypeVersion">1</property>
<property name="thingTypeVersion">2</property>
</properties>
<representation-property>host</representation-property>
<config-description-ref uri="thing-type:daikin:config"/>
Expand All @@ -70,8 +70,8 @@
<channels>
<channel id="power" typeId="acunit-power"/>
<channel id="settemp" typeId="acunit-settemp"/>
<channel id="indoortemp" typeId="acunit-indoortemp"/>
<channel id="outdoortemp" typeId="acunit-outdoortemp"/>
<channel id="indoortemp" typeId="system.indoor-temperature"/>
<channel id="outdoortemp" typeId="system.outdoor-temperature"/>
<channel id="mode" typeId="acunit-mode"/>
<channel id="homekitmode" typeId="acunit-homekitmode"/>
<channel id="airbasefanspeed" typeId="airbase-acunit-fan"/>
Expand All @@ -85,6 +85,9 @@
<channel id="zone8" typeId="airbase-acunit-zone8"/>
</channels>

<properties>
<property name="thingTypeVersion">1</property>
</properties>
<representation-property>host</representation-property>
<config-description-ref uri="thing-type:daikin:config"/>
</thing-type>
Expand All @@ -94,6 +97,10 @@
<label>Power</label>
<description>Power for the AC unit</description>
<category>Switch</category>
<tags>
<tag>Switch</tag>
<tag>Power</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

Expand All @@ -102,26 +109,14 @@
<label>Set Point</label>
<description>The set point temperature</description>
<category>Temperature</category>
<tags>
<tag>Setpoint</tag>
<tag>Temperature</tag>
</tags>
<state pattern="%.1f %unit%" step="0.5"/>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="acunit-indoortemp">
<item-type>Number:Temperature</item-type>
<label>Indoor Temperature</label>
<description>The indoor temperature</description>
<category>Temperature</category>
<state readOnly="true" pattern="%.1f %unit%" step="0.5"/>
</channel-type>

<channel-type id="acunit-outdoortemp">
<item-type>Number:Temperature</item-type>
<label>Outdoor Temperature</label>
<description>The outdoor temperature</description>
<category>Temperature</category>
<state readOnly="true" pattern="%.1f %unit%" step="0.5"/>
</channel-type>

<channel-type id="acunit-humidity" advanced="true">
<item-type unitHint="%">Number:Dimensionless</item-type>
<label>Indoor Humidity</label>
Expand All @@ -134,6 +129,10 @@
<item-type>String</item-type>
<label>Mode</label>
<description>Current mode of the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Mode</tag>
</tags>
<state>
<options>
<option value="AUTO">auto</option>
Expand Down Expand Up @@ -165,6 +164,10 @@
<item-type>String</item-type>
<label>Fan</label>
<description>Current fan speed setting of the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Level</tag>
</tags>
<state>
<options>
<option value="AUTO">auto</option>
Expand Down Expand Up @@ -471,62 +474,98 @@
<item-type>String</item-type>
<label>Fan</label>
<description>Current fan speed setting of the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Level</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone1">
<item-type>Switch</item-type>
<label>Zone 1</label>
<description>Zone 1 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone2">
<item-type>Switch</item-type>
<label>Zone 2</label>
<description>Zone 2 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone3">
<item-type>Switch</item-type>
<label>Zone 3</label>
<description>Zone 3 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone4">
<item-type>Switch</item-type>
<label>Zone 4</label>
<description>Zone 4 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone5">
<item-type>Switch</item-type>
<label>Zone 5</label>
<description>Zone 5 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone6">
<item-type>Switch</item-type>
<label>Zone 6</label>
<description>Zone 6 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone7">
<item-type>Switch</item-type>
<label>Zone 7</label>
<description>Zone 7 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

<channel-type id="airbase-acunit-zone8">
<item-type>Switch</item-type>
<label>Zone 8</label>
<description>Zone 8 for the AC unit</description>
<tags>
<tag>Control</tag>
<tag>Airflow</tag>
</tags>
<autoUpdatePolicy>veto</autoUpdatePolicy>
</channel-type>

Expand Down
68 changes: 68 additions & 0 deletions bundles/org.openhab.binding.daikin/src/main/resources/OH-INF/update/update.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,27 @@
xsi:schemaLocation="https://openhab.org/schemas/update-description/v1.0.0 https://openhab.org/schemas/update-description-1.0.0.xsd">

<thing-type uid="daikin:ac_unit">
<instruction-set targetVersion="2">
<update-channel id="power">
<type>daikin:acunit-power</type>
</update-channel>
<update-channel id="settemp">
<type>daikin:acunit-settemp</type>
</update-channel>
<update-channel id="indoortemp">
<type>system:indoor-temperature</type>
</update-channel>
<update-channel id="outdoortemp">
<type>system:outdoor-temperature</type>
</update-channel>
<update-channel id="mode">
<type>daikin:acunit-mode</type>
</update-channel>
<update-channel id="fanspeed">
<type>daikin:acunit-fan</type>
</update-channel>
</instruction-set>

<instruction-set targetVersion="1">
<add-channel id="demandcontrolmode">
<type>daikin:acunit-demandcontrolmode</type>
Expand All @@ -17,4 +38,51 @@
</instruction-set>
</thing-type>

<thing-type uid="daikin:airbase_ac_unit">
<instruction-set targetVersion="1">
<update-channel id="power">
<type>daikin:acunit-power</type>
</update-channel>
<update-channel id="settemp">
<type>daikin:acunit-settemp</type>
</update-channel>
<update-channel id="indoortemp">
<type>system:indoor-temperature</type>
</update-channel>
<update-channel id="outdoortemp">
<type>system:outdoor-temperature</type>
</update-channel>
<update-channel id="mode">
<type>daikin:acunit-mode</type>
</update-channel>
<update-channel id="airbasefanspeed">
<type>daikin:airbase-acunit-fan</type>
</update-channel>
<update-channel id="zone1">
<type>daikin:airbase-acunit-zone1</type>
</update-channel>
<update-channel id="zone2">
<type>daikin:airbase-acunit-zone2</type>
</update-channel>
<update-channel id="zone3">
<type>daikin:airbase-acunit-zone3</type>
</update-channel>
<update-channel id="zone4">
<type>daikin:airbase-acunit-zone4</type>
</update-channel>
<update-channel id="zone5">
<type>daikin:airbase-acunit-zone5</type>
</update-channel>
<update-channel id="zone6">
<type>daikin:airbase-acunit-zone6</type>
</update-channel>
<update-channel id="zone7">
<type>daikin:airbase-acunit-zone7</type>
</update-channel>
<update-channel id="zone8">
<type>daikin:airbase-acunit-zone8</type>
</update-channel>
</instruction-set>
</thing-type>

</update:update-descriptions>