Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera] Add reboot action for Reolink ipcamera #18337

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

simmonyau
Copy link
Contributor

Add reboot channel for Reolink ipcam

This PR adds support for a reboot channel for Reolink ipcams.

It has been tested successfully on a Reolink Duo Floodlight POE camera.

@simmonyau simmonyau requested a review from Skinah as a code owner February 28, 2025 06:34
@simmonyau simmonyau changed the title Add reboot channel for Reolink ipcam [ipcamera] Add reboot channel for Reolink ipcam Feb 28, 2025
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left some comments to fix. Otherwise LGTM.
Please be sure it is well tested to prevent regressions.

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Feb 28, 2025
simmonyau and others added 2 commits March 1, 2025 10:11
…/thing/thing-types.xml

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Simmon Yau <[email protected]>
and ran i18n plugin to generate new ipcamera.properties.

Signed-off-by: Simmon Yau <[email protected]>
@simmonyau simmonyau force-pushed the reolink-reboot branch 2 times, most recently from 754caf3 to 0c438ff Compare March 1, 2025 21:39
@simmonyau simmonyau requested a review from lsiepel March 1, 2025 21:42
@simmonyau simmonyau changed the title [ipcamera] Add reboot channel for Reolink ipcam [ipcamera] Add reboot action for Reolink ipcamera Mar 1, 2025
@simmonyau
Copy link
Contributor Author

This PR has been changed to add a reboot action (instead of channel) for the Reolink ipcamera which has been tested successfully on Reolink Duo Floodlight POE.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.
Would be nice if @Skinah can confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants