-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ipcamera] Add reboot action for Reolink ipcamera #18337
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simmon Yau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I left some comments to fix. Otherwise LGTM.
Please be sure it is well tested to prevent regressions.
...hab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/ReolinkHandler.java
Show resolved
Hide resolved
bundles/org.openhab.binding.ipcamera/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.ipcamera/src/main/resources/OH-INF/i18n/ipcamera.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.ipcamera/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
…/thing/thing-types.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Simmon Yau <[email protected]>
and ran i18n plugin to generate new ipcamera.properties. Signed-off-by: Simmon Yau <[email protected]>
754caf3
to
0c438ff
Compare
Signed-off-by: Simmon Yau <[email protected]>
0c438ff
to
b5da329
Compare
This PR has been changed to add a reboot action (instead of channel) for the Reolink ipcamera which has been tested successfully on Reolink Duo Floodlight POE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Would be nice if @Skinah can confirm.
Add reboot channel for Reolink ipcam
This PR adds support for a reboot channel for Reolink ipcams.
It has been tested successfully on a Reolink Duo Floodlight POE camera.