Making use of diffable data source #744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Tim Bert <[email protected]>
…med to OpenHABSelectionCollectionViewController Migrated OpenHABSelectionCollectionViewController away from Storyboard Showing view controllers, rather than pushing them, see https://www.swiftbysundell.com/tips/showing-view-controllers/ Signed-off-by: Tim Bert <[email protected]>
…med to OpenHABSelectionCollectionViewController Migrated OpenHABSelectionCollectionViewController away from Storyboard Showing view controllers, rather than pushing them, see https://www.swiftbysundell.com/tips/showing-view-controllers/ Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Tim Bert <[email protected]>
…med to OpenHABSelectionCollectionViewController Migrated OpenHABSelectionCollectionViewController away from Storyboard Showing view controllers, rather than pushing them, see https://www.swiftbysundell.com/tips/showing-view-controllers/ Migrated OpenHABSitemapViewController to diffable data source / Avoiding reloadData() Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Tim Bert <[email protected]>
Signed-off-by: Tim Bert <[email protected]>
Making the code more maintainable Signed-off-by: Tim Bert <[email protected]>
timbms
requested review from
digitaldan and
weakfl
and removed request for
digitaldan
Signed-off-by: Tim Bert <[email protected]>
Port switchsupport to branch diffable
…nHABWidget> using swift-collections
Getting the separatorInset back Reverting diffable data source to work on OpenHABWidget instead of OpenHABWidget.ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffable data source is a feature introduced in WWDC 2019. It eliminates a lot of boiler plate code:
Required deployment target iOS 14 should not be showstopper anymore