Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockly] Make HTTP block method name dropdown labels less technical #2740

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Sep 2, 2024

See #2607 (comment)

@ysc @stefan-hoehn For your evaluation.

It looks like it does not create backward compatibility issues, so this change should be fine. If this is accepted, I will change the screenshots again in openhab/openhab-docs#2359

Signed-off-by: Mark Herwege <[email protected]>
@mherwege mherwege requested a review from a team as a code owner September 2, 2024 08:16
Copy link

relativeci bot commented Sep 2, 2024

#2233 Bundle Size — 10.83MiB (~-0.01%).

1457318(current) vs 22a42c3 main#2232(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2233
     Baseline
#2232
No change  Initial JS 1.89MiB 1.89MiB
No change  Initial CSS 576.5KiB 576.5KiB
Change  Cache Invalidation 17.97% 0.01%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2914 2914
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#2233
     Baseline
#2232
Improvement  JS 9.05MiB (~-0.01%) 9.05MiB
No change  CSS 862.92KiB 862.92KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.36KiB 1.36KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:blockly_http_methodname...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Sep 3, 2024
@stefan-hoehn
Copy link
Contributor

In favor of keeping blocks as short as possible, can we omit the word "request" somehow? Like "send HTTP GET to" ?

Signed-off-by: Mark Herwege <[email protected]>
@mherwege
Copy link
Contributor Author

mherwege commented Sep 6, 2024

In favor of keeping blocks as short as possible, can we omit the word "request" somehow? Like "send HTTP GET to" ?

Yes, done.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏻
@florian-h05 pls merge

@florian-h05 florian-h05 changed the title [Blockly] HTTP block, change method name dropdown labels to be less technical [blockly] Make HTTP block method name dropdown labels less technical Sep 7, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Sep 7, 2024
@florian-h05 florian-h05 merged commit 99a9c0a into openhab:main Sep 7, 2024
8 checks passed
@mherwege mherwege deleted the blockly_http_methodnames branch September 7, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants