-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSim-compatible updates for CV32E20 #2557
base: master
Are you sure you want to change the base?
Conversation
Hi @zchamski and @AyoubJalali, I am hoping that you can both spare some time to review this PR. These are changes that should not affect CVA6, but I want to be double-sure before merging. Below is summary of the changes:
|
LGTM ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a typo in variable name LGTM. RTL cleanup is a separate story (and should be a separate task).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For info, I am trying CVA6 with this PR. I let you know. |
This is a companion PR to openhwgroup/cv32e20-dv#3.