Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSim-compatible updates for CV32E20 #2557

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

MikeOpenHWGroup
Copy link
Member

This is a companion PR to openhwgroup/cv32e20-dv#3.

@MikeOpenHWGroup
Copy link
Member Author

Hi @zchamski and @AyoubJalali, I am hoping that you can both spare some time to review this PR. These are changes that should not affect CVA6, but I want to be double-sure before merging.

Below is summary of the changes:

  • .gitignore : a little clean-up. Does not affect functionality of any env using core-v-verif.
  • LICENSE.md : a little clean-up. Does not affect functionality of any env using core-v-verif.
  • lib/uvm_agents/uvma_core_cntrl/uvma_core_cntrl_tdefs.sv : define is_active as a uvm_active_passive_enum, instead of a bit. This was a latent bug that VCS doesn't care about, but DSim (correctly) throws a compiel error.
  • lib/uvm_agents/uvma_obi_memory/src/seq/uvma_obi_memory_vp_base_seq.sv : delete whitespace, update comments and add one additional call to uvm_info. No impact on functionality.
  • lib/uvm_components/uvmc_rvfi_reference_model/uvmc_rvfi_spike.sv : Change of functionality! Only call Spike tasks if USE_ISS is set.
  • lib/uvm_components/uvmc_rvfi_scoreboard/uvmc_rvfi_scoreboard.sv : Change of functionality! Only call Spike tasks if USE_ISS is set.
  • lib/uvm_components/uvmc_rvfi_scoreboard/uvmc_rvfi_scoreboard_utils.sv : add a TODO comment. No change in functionality.
  • mk/Common.mk : add banner to target svlib. Add new vars and targets rvvi_stub. No change in functionality.
  • mk/uvmt/dsim.mk : Significant updates. Only affects users of DSim.
  • mk/uvmt/uvmt.mk : Add new vars and new target to display vars. No change in functionality.
  • vendor_lib/.gitignore : Fix to prevent svlib.so from Verilab being checked in (should be generated).

@MikeOpenHWGroup MikeOpenHWGroup marked this pull request as ready for review November 28, 2024 17:26
@AyoubJalali
Copy link
Contributor

LGTM !

Copy link
Contributor

@zchamski zchamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a typo in variable name LGTM. RTL cleanup is a separate story (and should be a separate task).

mk/Common.mk Outdated Show resolved Hide resolved
mk/uvmt/dsim.mk Show resolved Hide resolved
Copy link
Contributor

@zchamski zchamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JeanRochCoulon
Copy link
Contributor

For info, I am trying CVA6 with this PR. I let you know.

@JeanRochCoulon
Copy link
Contributor

When using this PR in CVA6 project, I get this error message:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants