C API header xcvsimd and type fixes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the types of simd CORE-V Clang builtins as per spec. The patch also adds the `I` qualifier to the immediate argument of extract[u]_[h,b] intrinsics so that clang errors when a variable is passed instead of letting the compiler crash later. The patch also updates the clang CoreGen test accordingly.
This commit adds the C API header to serve as an interface for the intrinsic functions provided with the CORE-V xcvsimd extension. The commit includes the addition of the header itself and a clang CodeGen test that checks the integrity of the call to the wrapper functions designed in the C API CORE-V simd header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the C API header file for the xcvsimd Clang builtins.
It adds the CodeGen test that checks that the wrapper functions defined in the header turn into the right LLVM instrinsic when called.
The patch also adds a fix for the types of the operands of some simd builtins that were wrongly declared as signed instead of unsigned or as not constant arguments.
The CodeGen tests are updated accordingly.
Finally the patch adds the cmake support for the header file. This needs to follow the analogous patch for the xcvbitmanip builtins as that one includes the basic cmake support to add all the headers.