Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored v1 headers and added same header to new files. #964

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

pascalgouedo
Copy link

No description provided.

@pascalgouedo pascalgouedo added Type:Enhancement For feature requests and enhancements Component:RTL For issues in the RTL (e.g. for files in the rtl directory) labels Mar 20, 2024
Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All but one of the files changes in this PR are updates to license headers. These look OK and I am approving this PR on that basis.

The change to rtl/cv32e40p_fp_wrapper.sv adds a new parameter (FPU_ADDMUL_LAT). I am not in a position to comment on that.

@pascalgouedo
Copy link
Author

pascalgouedo commented Mar 21, 2024

The change to rtl/cv32e40p_fp_wrapper.sv adds a new parameter (FPU_ADDMUL_LAT). I am not in a position to comment on that.

rtl/cv32e40p_fp_wrapper.sv has 2 new parameters (FPU_ADDMUL_LAT and FPU_OTHERS_LAT) with respect to v1 to replace package defines by top level parameters.

@pascalgouedo
Copy link
Author

pascalgouedo commented Mar 21, 2024

All but one of the files changes in this PR are updates to license headers. These look OK and I am approving this PR on that basis.

In fact I restored files to v1 headers because between v1 and now I already updated some of them to what I expected to be final headers.
But by making diff between v1 and now you will finally see much less updated files, aligning to the excel list I sent to mattermost.

@pascalgouedo pascalgouedo added Status:Do-not-merge Pull request that should not be merged (yet) and removed Status:Do-not-merge Pull request that should not be merged (yet) labels Mar 22, 2024
@DBees
Copy link

DBees commented Mar 25, 2024

@pascalgouedo I have reviewed files with the help of your spreadsheet. My understanding is that in case of modified files from V1, you have updated the existing header to add your copyright and in the case of newly created files, you have created the license with Solderpad 2.1. It looks good to me, so I approve.

Copy link

@Floadv298 Floadv298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pascalgouedo
restoring the original Copyright and adding Dolphin on new one looks good to me, thanks!

@pascalgouedo pascalgouedo merged commit c807945 into openhwgroup:dev Mar 26, 2024
3 checks passed
@pascalgouedo pascalgouedo deleted the dev_dd_pgo_rtl_headers branch March 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Type:Enhancement For feature requests and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants