fix single-step which was x in cv32a65x config and fix mcycle for dou…

…ble commit (#2369)
openhwgroup · Aug 22, 2024 · 76e5b40 · 76e5b40
1 parent 12f41b5
commit 76e5b40
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/core/csr_regfile.sv b/core/csr_regfile.sv
@@ -2515,7 +2515,7 @@ module csr_regfile
   // determine if mprv needs to be considered if in debug mode
   assign mprv = (CVA6Cfg.DebugEn && debug_mode_q && !dcsr_q.mprven) ? 1'b0 : mstatus_q.mprv;
   assign debug_mode_o = debug_mode_q;
-  assign single_step_o = dcsr_q.step;
+  assign single_step_o = CVA6Cfg.DebugEn ? dcsr_q.step : 1'b0;
   assign mcountinhibit_o = {{29 - MHPMCounterNum{1'b0}}, mcountinhibit_q};
 
   // sequential process

diff --git a/core/cva6.sv b/core/cva6.sv
@@ -1508,6 +1508,7 @@ module cva6
     assign halt_acc_ctrl              = '0;
     assign stall_st_pending_ex        = '0;
     assign flush_acc                  = '0;
+    assign single_step_acc_commit     = '0;
 
     // D$ connection is unused
     assign dcache_req_ports_acc_cache = '0;

diff --git a/verif/env/uvme/uvme_cva6_env.sv b/verif/env/uvme/uvme_cva6_env.sv
@@ -174,6 +174,8 @@ function void uvme_cva6_env_c::build_phase(uvm_phase phase);
       `uvm_info("CVA6Cfg", $sformatf("Found RTL configuration handle:\n%p", cfg.CVA6Cfg), UVM_DEBUG)
    end
 
+   cfg.rvfi_cfg.nret = cfg.CVA6Cfg.NrCommitPorts;
+
    if (cfg.enabled) begin
       void'(uvm_config_db#(uvme_cva6_cntxt_c)::get(this, "", "cntxt", cntxt));
       if (!cntxt) begin

diff --git a/verif/env/uvme/uvme_cva6_sb.sv b/verif/env/uvme/uvme_cva6_sb.sv
@@ -353,7 +353,7 @@ function bit [XLEN:0] uvme_cva6_sb_c::check_mcycle_h(uvma_isacov_instr_c instr,
          overflow = 1;
       end
       else begin
-         `uvm_error(get_type_name(), $sformatf("ERROR : No overflow - MCYCLE isn't incremented"))
+         `uvm_error(get_type_name(), $sformatf("ERROR : No overflow - MCYCLE isn't incremented, %d - %d", mcycle_read, mcycle_prev))
          overflow = 0;
       end
    end
@@ -484,7 +484,9 @@ task uvme_cva6_sb_c::run_phase(uvm_phase phase);
               instr_trn_fifo.get(instr_trn);
               check_pc_trap(instr_trn.instr, instr_prev);
               check_mepc(instr_trn.instr);
-              mcycle_update = check_mcycle_h(instr_trn.instr, instr_prev, read_cycle);
+              if (instr_trn.instr.rvfi.nret_id == 0) begin
+                 mcycle_update = check_mcycle_h(instr_trn.instr, instr_prev, read_cycle);
+              end
               // Move instructions down the pipeline
               instr_prev = instr_trn.instr;
           end