-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bp: add BHT with private history #2793
base: master
Are you sure you want to change the base?
Conversation
❌ failed run, report available here. |
1 similar comment
❌ failed run, report available here. |
❌ failed run, report available here. |
@@ -62,6 +62,8 @@ package cva6_config_pkg; | |||
localparam CVA6ConfigRASDepth = 2; | |||
localparam CVA6ConfigBTBEntries = 0; | |||
localparam CVA6ConfigBHTEntries = 32; | |||
localparam CVA6ConfigBHTHist = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to not use localparam, this can generate bugs because localparam is static and parameter is dynamic (can be configured from outside).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring only to the CVA6ConfigBHTHist
parameter? What would be the recommended solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, BHTHist
should be a tuneable parameter like the remaining ones. My understanding is that cv32a60x and cv32a65x are hardcoded, while remaining config packages have the localparam
pattern to tune them. Do you think BHTHist
only should be hardcoded?
❌ failed run, report available here. |
❌ failed run, report available here. |
1 similar comment
❌ failed run, report available here. |
Co-authored-by: Riccardo Tedeschi <[email protected]>
❌ failed run, report available here. |
This PR adds a new two-level BHT predictor with private history, as depicted below. The new
BPType
parameters allow choosing between the original BHT and the new one.