-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added avalonia sample app and detailed description #2199
base: rel/5.8.0
Are you sure you want to change the base?
Conversation
a0d75d1
to
3f594f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
...OpenIddict.Sandbox.Avalonia.Client.Android/OpenIddict.Sandbox.Avalonia.Client.Android.csproj
Outdated
Show resolved
Hide resolved
...ct.Sandbox.Avalonia.Client/OpenIddict.Sandbox.Avalonia.Client/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
...ddict.Sandbox.Avalonia.Client/OpenIddict.Sandbox.Avalonia.Client/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,482 @@ | |||
# Avalonia sample app guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These samples are engineering samples - hence the name, "sandbox" - meant to be used to test OpenIddict features as they are being developed. They are not meant to be used by the general public, so this is likely not the right place for this guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I can add this to the official docs then and reduce this to
How to run the sample on iOS and Android
- set the issuer URI on client and server
- and start the server in dev tunnel with host header forwarding
- for details, please check out the guide on using dev tunnels (that I am going to write)
Would that be ok?
Honestly, no idea: OpenIddict doesn't do anything fancy and simply uses .NET Arcade.
If we can fix the build issues in a way it doesn't prevent the solution from building correctly and eliminate all the tiny extensions/classes - aka "make it minimal" - so it doesn't become a pain to maintain, I don't mind merging it 😄 |
f9e6114
to
c50e147
Compare
c50e147
to
0f592bf
Compare
Hello!
Me again.
I managed to fix the build.
Directory.packages.props
file.However, the
.\build.cmd
fails with the ".Android" and ".iOS" Avalonia projects claiming:Interestingly, when I run
dotnet build
in the openiddict-core root folder, I get a similar error.However, if I specify the Android sdk explicitly, like the following, then the build succeeds:
It seems that for whatever reason the
.\build.cmd
does not pick up the sdks properly.Any idea why that is the case?
I am terribly sorry for asking this question, but I could not figure out your complex build script until now :-|
Once that is fixed, I am
Before I do that, please let me know if this effort is welcome. Otherwise I'll create a sample in the avalonia repo as an alternative. But for that I'd have to copy your
OpenIddict.Sandbox.AspNet.Server
andOpenIddict.Sandbox.AspNetCore.Server
and I am not sure if that is ok (given your OS license)