Support for Zendesk #2217
Support for Zendesk #2217
Conversation
| TokenEndpoint="https://{settings.Tenant}.zendesk.com/oauth/tokens" | ||
| UserInfoEndpoint="https://{settings.Tenant}.zendesk.com/api/v2/users/me"> | ||
| <CodeChallengeMethod Value="S256" /> | ||
| <GrantType Value="authorization_code" /> |
There was a problem hiding this comment.
| <GrantType Value="authorization_code" /> |
When authorization_code is the only grant type supported, adding it explicitly isn't required as it's always added by the provider generator when you don't explicitly set a list of grant types.
| <Setting PropertyName="ClientType" ParameterName="kind" Type="String" Required="false" | ||
| DefaultValue="confidential" Description="Client Type: public or confidential. Public OAuth clients are applications that run in environments where credentials cannot be securely stored, such as mobile and web apps. These clients are required to use PKCE. Confidential OAuth clients run on secure servers where their credentials can be kept secure. These clients can use PKCE, client secret, or both." /> |
There was a problem hiding this comment.
| <Setting PropertyName="ClientType" ParameterName="kind" Type="String" Required="false" | |
| DefaultValue="confidential" Description="Client Type: public or confidential. Public OAuth clients are applications that run in environments where credentials cannot be securely stored, such as mobile and web apps. These clients are required to use PKCE. Confidential OAuth clients run on secure servers where their credentials can be kept secure. These clients can use PKCE, client secret, or both." /> |
This setting shouldn't be needed (and since you didn't write custom code to do something based on its value, it really has no effect whatsoever) 😃
| </Configuration> | ||
| </Environment> | ||
| <Setting PropertyName="Tenant" ParameterName="tenant" Type="String" Required="true" | ||
| Description="Gets or sets the tenant used to identify the Zendesk instance." /> |
There was a problem hiding this comment.
| Description="Gets or sets the tenant used to identify the Zendesk instance." /> | |
| Description="Gets or sets the tenant used to identify the Zendesk instance" /> |
(the . is automagically added by the generator)
| @@ -2153,6 +2153,27 @@ | |||
| <Environment Issuer="https://api.login.yahoo.com/" /> | |||
| </Provider> | |||
|
|
|||
| <Provider Name="Zendesk" Id="5577b117-1f3d-464f-b987-aabf7c0ab3f7" Documentation="https://developer.zendesk.com/api-reference/introduction/security-and-auth/#oauth-access-token"> | |||
There was a problem hiding this comment.
| <Provider Name="Zendesk" Id="5577b117-1f3d-464f-b987-aabf7c0ab3f7" Documentation="https://developer.zendesk.com/api-reference/introduction/security-and-auth/#oauth-access-token"> | |
| <Provider Name="Zendesk" Id="5577b117-1f3d-464f-b987-aabf7c0ab3f7" Documentation="https://support.zendesk.com/hc/en-us/articles/4408845965210-Using-OAuth-authentication-with-your-application"> |
Let's use https://support.zendesk.com/hc/en-us/articles/4408845965210-Using-OAuth-authentication-with-your-application instead of https://developer.zendesk.com/api-reference/introduction/security-and-auth/#oauth-access-token as the last one doesn't contain anything really useful.
|
Hey @mozts2005, If you have any question or need help to complete this PR, please let me know 😃 Cheers. |
I have added Support for Zendesk. I am happy to help in testing validation as I have an account with Zendesk that is used for Open-source project testing.