-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add maui sample link to readme #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Given that the MAUI sample is an experimental sample that only supports WinUI 3, I'd prefer listing it in the external samples category.
README.md
Outdated
@@ -15,6 +15,7 @@ This repository contains samples demonstrating **how to use [OpenIddict](https:/ | |||
- [Velusia](samples/Velusia): authorization code flow demo, with an ASP.NET Core application acting as the client. | |||
- [Weytta](samples/Weytta): authorization code flow with Integrated Windows Authentication support and a .NET console acting as the client. | |||
- [Zirku](samples/Zirku): authorization code flow demo using minimal APIs with 2 hard-coded user identities, a .NET console and a SPA acting as the clients and two API projects using introspection (Api1) and local validation (Api2). | |||
- [Sandbox](https://github.com/kevinchalet/openiddict-core/tree/maui_winui_sample/sandbox): .net maui sample. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move that to the External samples
section and change the description to experimental MAUI (WinUI-only) sample
?
- **[Experimental MAUI (WinUI-only) sample](https://github.com/kevinchalet/openiddict-core/tree/maui_winui_sample/sandbox/OpenIddict.Sandbox.Maui.Client)** by [Kévin Chalet](https://github.com/kevinchalet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me update the pr tonight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
FYI, I just rebased the |
Merged. Congrats for your first contribution to OpenIddict 🎉 |
so that user can easy to find how to integrate with maui