Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maui sample link to readme #256

Merged
merged 2 commits into from
Oct 10, 2023
Merged

add maui sample link to readme #256

merged 2 commits into from
Oct 10, 2023

Conversation

jingliancui
Copy link
Contributor

so that user can easy to find how to integrate with maui

Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Given that the MAUI sample is an experimental sample that only supports WinUI 3, I'd prefer listing it in the external samples category.

README.md Outdated
@@ -15,6 +15,7 @@ This repository contains samples demonstrating **how to use [OpenIddict](https:/
- [Velusia](samples/Velusia): authorization code flow demo, with an ASP.NET Core application acting as the client.
- [Weytta](samples/Weytta): authorization code flow with Integrated Windows Authentication support and a .NET console acting as the client.
- [Zirku](samples/Zirku): authorization code flow demo using minimal APIs with 2 hard-coded user identities, a .NET console and a SPA acting as the clients and two API projects using introspection (Api1) and local validation (Api2).
- [Sandbox](https://github.com/kevinchalet/openiddict-core/tree/maui_winui_sample/sandbox): .net maui sample.
Copy link
Member

@kevinchalet kevinchalet Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move that to the External samples section and change the description to experimental MAUI (WinUI-only) sample?

- **[Experimental MAUI (WinUI-only) sample](https://github.com/kevinchalet/openiddict-core/tree/maui_winui_sample/sandbox/OpenIddict.Sandbox.Maui.Client)** by [Kévin Chalet](https://github.com/kevinchalet)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me update the pr tonight.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kevinchalet
Copy link
Member

FYI, I just rebased the maui_winui_sample branch and updated the sample to use the new ChallengeInteractivelyAsync()/AuthenticateInteractivelyAsync() APIs introduced in OpenIddict 4.5.0.

@kevinchalet kevinchalet self-assigned this Oct 10, 2023
@kevinchalet kevinchalet merged commit c01eb62 into openiddict:dev Oct 10, 2023
3 checks passed
@kevinchalet
Copy link
Member

Merged. Congrats for your first contribution to OpenIddict 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants