Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57 #23362

Closed
wants to merge 1 commit into from

Conversation

satyenme
Copy link
Contributor

@satyenme satyenme commented Jan 30, 2025

Renaming ShenandoahEvacuationInformation.freedRegions to ShenandoahEvacuationInformation.freeRegions for clarity, and fixing incorrect assertion in TestShenandoahEvacuationInformationEvent.cpp

Tested with tier 1, tier 2, and tier 3 tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23362/head:pull/23362
$ git checkout pull/23362

Update a local copy of the PR:
$ git checkout pull/23362
$ git pull https://git.openjdk.org/jdk.git pull/23362/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23362

View PR using the GUI difftool:
$ git pr show -t 23362

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23362.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57

Reviewed-by: wkemper, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • ee4caa4: 8349106: Change ChaCha20 intrinsic to use quarter-round parallel implementation on aarch64
  • b985347: 8348349: Refactor CDSConfig::is_dumping_heap()
  • beb43e2: 8349343: Add missing copyright messages in FFM benchmarks
  • e91a6ec: 8347489: RISC-V: Misaligned memory access with COH
  • d699aba: 8349135: Add tests for HttpRequest.Builder.copy()
  • 81126c2: 8349238: Some more FFM benchmarks are broken
  • beae884: 8349150: Support precompiled headers on AIX
  • c545a3e: 8346774: Use Predicate classes instead of Node classes
  • 7ea176d: 8349193: compiler/intrinsics/TestContinuationPinningAndEA.java missing @requires vm.continuations
  • 9b49597: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary
  • ... and 49 more: https://git.openjdk.org/jdk/compare/d985b31cbb5646c526e1a68a7547f26f56d37607...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@satyenme The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 4, 2025
@satyenme
Copy link
Contributor Author

satyenme commented Feb 4, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 4, 2025
@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@satyenme
Your change (at version 923a29d) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 4, 2025

Going to push as commit bad39b6.
Since your change was applied there have been 60 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2025
@openjdk openjdk bot closed this Feb 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 4, 2025
@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@phohensee @satyenme Pushed as commit bad39b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants