Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349017: Update ML tests to verify against ACVP 1.1.0.38 version #23370

Closed
wants to merge 4 commits into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jan 30, 2025

This fix updates compatibility tests with verification against ACVP 1.1.0.38 data. The new data files in v1.1.0.38 are significantly larger in file size so they are moved to artifactory or are to be provided for local run. Refer to Launcher.java for more details on this.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349017: Update ML tests to verify against ACVP 1.1.0.38 version (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23370/head:pull/23370
$ git checkout pull/23370

Update a local copy of the PR:
$ git checkout pull/23370
$ git pull https://git.openjdk.org/jdk.git pull/23370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23370

View PR using the GUI difftool:
$ git pr show -t 23370

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23370.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349017: Update ML tests to verify against ACVP 1.1.0.38 version

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 31, 2025
@rhalade
Copy link
Member Author

rhalade commented Jan 31, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

Going to push as commit 13d852a.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2025
@openjdk openjdk bot closed this Jan 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2025
@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@rhalade Pushed as commit 13d852a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants