8349122: -XX:+AOTClassLinking is not compatible with jdwp

[iklam]

Hi all,

This pull request contains a backport of commit 03f5c33b from the openjdk/jdk repository.

The commit being backported was authored by Ioi Lam on 31 Jan 2025 and was reviewed by John R Rose and Vladimir Kozlov.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349122: -XX:+AOTClassLinking is not compatible with jdwp (Bug - P2)

Reviewers

• John R Rose (@rose00 - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23381/head:pull/23381
$ git checkout pull/23381

Update a local copy of the PR:
$ git checkout pull/23381
$ git pull https://git.openjdk.org/jdk.git pull/23381/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23381

View PR using the GUI difftool:
$ git pr show -t 23381

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23381.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349122: -XX:+AOTClassLinking is not compatible with jdwp

Reviewed-by: jrose, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the jdk24 branch:

• 15f90f0: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version
• 926455d: 8345405: Add JMH showing the regression in 8341649

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (417b6a00)

[vnkozlov]

Good.

[iklam]

Thanks @rose00 @vnkozlov for the review
/integrate

[openjdk]

Going to push as commit 2a1a416.
Since your change was applied there have been 4 commits pushed to the jdk24 branch:

• 89c46f1: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
• b1b55f7: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
• 15f90f0: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version
• 926455d: 8345405: Add JMH showing the regression in 8341649

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 2a1a416.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.