-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters #23383
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back fmeum! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@jaikiran This is my attempt at making progress on https://mail.openjdk.org/pipermail/core-libs-dev/2024-November/135869.html without touching general URL/URI encoding code. I hope that this can fix the issue while avoiding backwards compatibility concerns. |
Webrevs
|
/reviewers:2 |
@AlanBateman Did you mean |
The reason this issue has been open in JBS for sometime is because it's a not a small project, and is fraught with danger. It's bigger and broader than the bug report suggests. Doing anything will require going over decisions make in JDK 1.2, and later in JDK 7 and working through all the compatibility issues that any changes in this area will have. |
/reviewers 2 |
URLClassPath
called intoParseUtil.fileToEncodedURL
, which misencoded characters with a four byte UTF-8 representation. Replacing that function withtoPath().toUri().toURL()
(and removing it, since its only used once) results in correct encoding for all Unicode characters.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23383/head:pull/23383
$ git checkout pull/23383
Update a local copy of the PR:
$ git checkout pull/23383
$ git pull https://git.openjdk.org/jdk.git pull/23383/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23383
View PR using the GUI difftool:
$ git pr show -t 23383
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23383.diff
Using Webrev
Link to Webrev Comment