8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters

[fmeum]

URLClassPath called into ParseUtil.fileToEncodedURL, which misencoded characters with a four byte UTF-8 representation. Replacing that function with toPath().toUri().toURL() (and removing it, since its only used once) results in correct encoding for all Unicode characters.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23383/head:pull/23383
$ git checkout pull/23383

Update a local copy of the PR:
$ git checkout pull/23383
$ git pull https://git.openjdk.org/jdk.git pull/23383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23383

View PR using the GUI difftool:
$ git pr show -t 23383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23383.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fmeum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@fmeum The following labels will be automatically applied to this pull request:

• core-libs
• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[fmeum]

@jaikiran This is my attempt at making progress on https://mail.openjdk.org/pipermail/core-libs-dev/2024-November/135869.html without touching general URL/URI encoding code. I hope that this can fix the issue while avoiding backwards compatibility concerns.

[mlbridge]

Webrevs

• 01: Full - Incremental (87be70b0)
• 00: Full (1846a5a8)

[AlanBateman]

/reviewers:2

[fmeum]

@AlanBateman Did you mean /reviewers 2? The required count per the PR body is still at 1.

[AlanBateman]

The reason this issue has been open in JBS for sometime is because it's a not a small project, and is fraught with danger. It's bigger and broader than the bug report suggests. Doing anything will require going over decisions make in JDK 1.2, and later in JDK 7 and working through all the compatibility issues that any changes in this area will have.

[jaikiran]

/reviewers 2

[openjdk]

@jaikiran
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).