Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters #23383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 31, 2025

URLClassPath called into ParseUtil.fileToEncodedURL, which misencoded characters with a four byte UTF-8 representation. Replacing that function with toPath().toUri().toURL() (and removing it, since its only used once) results in correct encoding for all Unicode characters.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23383/head:pull/23383
$ git checkout pull/23383

Update a local copy of the PR:
$ git checkout pull/23383
$ git pull https://git.openjdk.org/jdk.git pull/23383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23383

View PR using the GUI difftool:
$ git pr show -t 23383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23383.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2025

👋 Welcome back fmeum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8258246: sun.net.www.ParseUtil.decode 8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters Jan 31, 2025
@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@fmeum The following labels will be automatically applied to this pull request:

  • core-libs
  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@fmeum fmeum marked this pull request as ready for review January 31, 2025 12:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2025
@fmeum
Copy link
Contributor Author

fmeum commented Jan 31, 2025

@jaikiran This is my attempt at making progress on https://mail.openjdk.org/pipermail/core-libs-dev/2024-November/135869.html without touching general URL/URI encoding code. I hope that this can fix the issue while avoiding backwards compatibility concerns.

@mlbridge
Copy link

mlbridge bot commented Jan 31, 2025

Webrevs

@AlanBateman
Copy link
Contributor

/reviewers:2

@fmeum
Copy link
Contributor Author

fmeum commented Jan 31, 2025

@AlanBateman Did you mean /reviewers 2? The required count per the PR body is still at 1.

@AlanBateman
Copy link
Contributor

AlanBateman commented Feb 2, 2025

The reason this issue has been open in JBS for sometime is because it's a not a small project, and is fraught with danger. It's bigger and broader than the bug report suggests. Doing anything will require going over decisions make in JDK 1.2, and later in JDK 7 and working through all the compatibility issues that any changes in this area will have.

@jaikiran
Copy link
Member

jaikiran commented Feb 2, 2025

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 2, 2025

@jaikiran
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants