8348658: [AArch64] The node limit in compiler/codegen/TestMatcherClone.java is too strict

[dlunde]

Hi all,

This pull request contains a backport of commit ee87d187 from the openjdk/jdk repository.

The commit being backported was authored by Daniel Lundén on 31 Jan 2025 and was reviewed by Aleksey Shipilev and Vladimir Kozlov.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348658: [AArch64] The node limit in compiler/codegen/TestMatcherClone.java is too strict (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Emanuel Peter (@eme64 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23390/head:pull/23390
$ git checkout pull/23390

Update a local copy of the PR:
$ git checkout pull/23390
$ git pull https://git.openjdk.org/jdk.git pull/23390/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23390

View PR using the GUI difftool:
$ git pr show -t 23390

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23390.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlunden! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dlunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348658: [AArch64] The node limit in compiler/codegen/TestMatcherClone.java is too strict

Reviewed-by: shade, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the jdk24 branch:

• 5f5ed96: 8348890: Fix docs for -XX:AOT* options in java man page
• df57c97: 8348515: Add docs for -XX:AOT* options in java man pages
• 2a1a416: 8349122: -XX:+AOTClassLinking is not compatible with jdwp
• 89c46f1: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
• b1b55f7: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
• 15f90f0: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version
• 926455d: 8345405: Add JMH showing the regression in 8341649

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@dlunde The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (84bf8dda)

[shipilev]

There is no rush to do this in JDK 24 GA, but this is also a test-only change, so it formally passes the bar for RDP2.

[dlunde]

Thanks for the review @shipilev. Right, I thought it made sense to backport to 24 since it is such a small (test) change and we are still in RDP2.

[dlunde]

Thanks for the review @eme64.

/integrate

[openjdk]

Going to push as commit 47c15b5.
Since your change was applied there have been 7 commits pushed to the jdk24 branch:

• 5f5ed96: 8348890: Fix docs for -XX:AOT* options in java man page
• df57c97: 8348515: Add docs for -XX:AOT* options in java man pages
• 2a1a416: 8349122: -XX:+AOTClassLinking is not compatible with jdwp
• 89c46f1: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
• b1b55f7: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
• 15f90f0: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version
• 926455d: 8345405: Add JMH showing the regression in 8341649

Your commit was automatically rebased without conflicts.

[openjdk]

@dlunde Pushed as commit 47c15b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.