Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333867: SHA3 performance can be improved #1000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Sep 23, 2024

This is a clean backport of multi-platform SHA3 performance improvement. MessageDigests benchmarks show same speedup as for the original change (C2 generated code variant, -XX:-UseSHA3Intrinsics).

Testing: test/jdk/sun/security, tier1, tier2 (linux-aarch64, linux-amd64).


Progress

  • Change must not contain extraneous whitespace
  • JDK-8333867 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8333867: SHA3 performance can be improved (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1000/head:pull/1000
$ git checkout pull/1000

Update a local copy of the PR:
$ git checkout pull/1000
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1000

View PR using the GUI difftool:
$ git pr show -t 1000

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1000.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 75bea280b9adb6dac9fefafbb3f4b212f100fbb5 8333867: SHA3 performance can be improved Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

⚠️ @dchuyko This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2024

Webrevs

@dchuyko
Copy link
Member Author

dchuyko commented Sep 23, 2024

/approval request This is a clean backport of multi-platform SHA3 performance improvement. MessageDigests benchmarks show same C2 generated code speedup as for the original change. E.g. +25% on Graviton 2 on long arrays.

The patch removes unnecessary conversions between byte arrays and long arrays without changing the computation algorithm, only code related to SHA3 is modified, except the single private->protected blockSize change in DigestBase.

Testing: test/jdk/sun/security, tier1, tier2.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@dchuyko
8333867: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 23, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Oct 17, 2024

@dchuyko Please get this into a JDK 23 release (latest active STS), before proposing for JDK 21.

@openjdk openjdk bot removed the approval label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants