-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option #1024
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back toddjonker! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This streamlines configuration of our JDK+Graal distro, which in turn allows two failing tests to pass without modification. A corresponding backport PR for JDK23 is openjdk/jdk23u#136 |
@toddjonker |
Hi Todd, Also, how did you test this backport? |
Clean backport of patch authored by @tzezula and approved by @dougxc
The patch default-enables
useJVMCINativeLibrary
whenEnableJVMCI
is on andlibgraal
present. While this is a behavior change, it seems unlikely that users would deploylibgraal
and not want it used by JVMCI.This streamlines configuration of our JDK+Graal distro, which in turn allows two failing tests to pass without modification.
Equivalent backport to 23: openjdk/jdk23u#136
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1024/head:pull/1024
$ git checkout pull/1024
Update a local copy of the PR:
$ git checkout pull/1024
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1024/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1024
View PR using the GUI difftool:
$ git pr show -t 1024
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1024.diff
Webrev
Link to Webrev Comment