Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option #1024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toddjonker
Copy link
Contributor

@toddjonker toddjonker commented Oct 4, 2024

Clean backport of patch authored by @tzezula and approved by @dougxc

The patch default-enables useJVMCINativeLibrary when EnableJVMCI is on and libgraal present. While this is a behavior change, it seems unlikely that users would deploy libgraal and not want it used by JVMCI.

This streamlines configuration of our JDK+Graal distro, which in turn allows two failing tests to pass without modification.

Equivalent backport to 23: openjdk/jdk23u#136


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340398 needs maintainer approval

Issue

  • JDK-8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1024/head:pull/1024
$ git checkout pull/1024

Update a local copy of the PR:
$ git checkout pull/1024
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1024

View PR using the GUI difftool:
$ git pr show -t 1024

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1024.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2024

👋 Welcome back toddjonker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4cd8c75a55163be33917b1fba9f360ea816f3aa9 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 4, 2024
@openjdk openjdk bot added the clean label Oct 4, 2024
@toddjonker toddjonker marked this pull request as ready for review October 9, 2024 17:58
@openjdk
Copy link

openjdk bot commented Oct 9, 2024

⚠️ @toddjonker This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2024

Webrevs

@toddjonker
Copy link
Contributor Author

/approval request This streamlines configuration of our JDK+Graal distro, which in turn allows two failing tests to pass without modification. A corresponding backport PR for JDK23 is openjdk/jdk23u#136

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@toddjonker
8340398: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 14, 2024
@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2024

Hi Todd,
I'm not sure this is a good candidate for backport.
As you say, it will change the way the compilers are loaded and operated.
This might be quite unexpected for graal/truffle users if they update from 21.0.5 to 21.0.6.

Also, how did you test this backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants