-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled #1058
base: master
Are you sure you want to change the base?
8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled #1058
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport. Existing code is buggy when we define MEM_STATS to enable printing of memory statistic logs, leading to crash while disposing IJG stored objects in jmemmgr->free-pool() function. Change only reorders freeing of memory within |
Backporting JDK-8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled, which ensures we are clearing memory correctly if printing of memory statistic logs is enabled. Patch should be clean.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1058/head:pull/1058
$ git checkout pull/1058
Update a local copy of the PR:
$ git checkout pull/1058
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1058/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1058
View PR using the GUI difftool:
$ git pr show -t 1058
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1058.diff
Webrev
Link to Webrev Comment