Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled #1058

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Oct 16, 2024

Backporting JDK-8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled, which ensures we are clearing memory correctly if printing of memory statistic logs is enabled. Patch should be clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332866 needs maintainer approval

Issue

  • JDK-8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1058/head:pull/1058
$ git checkout pull/1058

Update a local copy of the PR:
$ git checkout pull/1058
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1058

View PR using the GUI difftool:
$ git pr show -t 1058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1058.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ca3072635215755766575b4eb70dc6267969a550 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2024

Webrevs

@satyenme
Copy link
Author

/approval request Clean backport. Existing code is buggy when we define MEM_STATS to enable printing of memory statistic logs, leading to crash while disposing IJG stored objects in jmemmgr->free-pool() function. Change only reorders freeing of memory within imageio_dispose() function. Tested with tier1, tier2, and GHA tests. Risk is low.

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@satyenme
8332866: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant