Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" #944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amosshi
Copy link

@amosshi amosshi commented Aug 24, 2024

Backport of JDK-8240343

  • This PR is generated by git patch command without .rej - it should be clean well the clean label was not added by bot

Testing

  • Local: Test passed on MacOS 14.6.1 on Apple M1 Max
    • Passed: vmTestbase/nsk/jdi/ListeningConnector/stopListening/stoplis001/TestDescription.java
  • Pipeline:
  • Testing Machine:

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8240343 needs maintainer approval

Issue

  • JDK-8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/944/head:pull/944
$ git checkout pull/944

Update a local copy of the PR:
$ git checkout pull/944
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/944/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 944

View PR using the GUI difftool:
$ git pr show -t 944

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/944.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 28b201955907e145f208d756b607ab545a83b2d3 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" Aug 24, 2024
@openjdk
Copy link

openjdk bot commented Aug 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 24, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2024

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant