8320682: [AArch64] C1 compilation fails with "Field too big for insn"

[bulasevich]

Hi all,

This is a backport of JDK-8320682 change to fix C1 internal error caused by adr limit being broken by too large NMethodSizeLimit option value.

The backported patch includes a change to the TestC1Globals.java that does not yet exist in the jdk21u codebase. In the mainline the test has four updates:

• [1] openjdk/jdk@7df73a23
• [2] openjdk/jdk@c36ec2ca
• [3] openjdk/jdk@69014cd5 (this change)
• [4] openjdk/jdk@27d5f5c2

With this change I simply copy version [3] of TestC1Globals.java corresponding to this change in jdk-23. Why not backport [1]+[2]+[3] to have a clean incremental patch?

• I do not think [1] fits the backporting rules (not a crash fix, and not very important)
• change [3] is stronger than change [2] (once NMethodSizeLimit is limited, no need to gracefully handle large values)

Testing: jtreg tier1-3.
Without the patch $ fastdebug/bin/java -XX:NMethodSizeLimit=4M causes the guarantee(chk == -1 || chk == 0) failed: Field too big for insn. With the change the 4M value becomes invalid.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8320682 needs maintainer approval

Issue

• JDK-8320682: [AArch64] C1 compilation fails with "Field too big for insn" (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/956/head:pull/956
$ git checkout pull/956

Update a local copy of the PR:
$ git checkout pull/956
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/956/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 956

View PR using the GUI difftool:
$ git pr show -t 956

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/956.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320682: [AArch64] C1 compilation fails with "Field too big for insn"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 76 new commits pushed to the master branch:

• fbfe11f: 8341024: [test] build/AbsPathsInImage.java fails with OOM when using ubsan-enabled binaries
• f766080: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
• 8e19c8f: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• f9070df: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
• e5dfeb1: 8342063: [21u][aix] Backport introduced redundant line in ProblemList
• 62e0147: Merge
• dfcd8d2: 8341989: [21u] Back out JDK-8327501 and JDK-8328366
• 0083bcd: 8341674: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.5
• 90517f5: 8332644: Improve graph optimizations
• 2058719: 8331446: Improve deserialization support
• ... and 66 more: https://git.openjdk.org/jdk21u-dev/compare/da4d2c58d3b7f1e7310b4f264a1cad05a983f522...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full (cbd4aa11)
• 00: Full (26767763)

[openjdk]

@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @bulasevich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[bulasevich]

/approval
The backport fixes C1 internal error caused by adr limit being broken by too large NMethodSizeLimit option value. The change is safe and simple. Let us do it.

[openjdk]

@bulasevich usage: /approval [<id>] (request|cancel) [<text>]

[bulasevich]

/approval request
The backport fixes C1 internal error caused by adr limit being broken by too large NMethodSizeLimit option value. The change is safe and simple. Let us do it.

[openjdk]

@bulasevich
8320682: The approval request has been created successfully.

[bulasevich]

/integrate

[openjdk]

@bulasevich
Your change (at version cbd4aa1) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 6ed940b.
Since your change was applied there have been 76 commits pushed to the master branch:

• fbfe11f: 8341024: [test] build/AbsPathsInImage.java fails with OOM when using ubsan-enabled binaries
• f766080: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
• 8e19c8f: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• f9070df: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
• e5dfeb1: 8342063: [21u][aix] Backport introduced redundant line in ProblemList
• 62e0147: Merge
• dfcd8d2: 8341989: [21u] Back out JDK-8327501 and JDK-8328366
• 0083bcd: 8341674: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.5
• 90517f5: 8332644: Improve graph optimizations
• 2058719: 8331446: Improve deserialization support
• ... and 66 more: https://git.openjdk.org/jdk21u-dev/compare/da4d2c58d3b7f1e7310b4f264a1cad05a983f522...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @bulasevich Pushed as commit 6ed940b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.