Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate #973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Sep 12, 2024

Clean backport. Change is confined to Shenandoah.


Progress

  • JDK-8336640 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/973/head:pull/973
$ git checkout pull/973

Update a local copy of the PR:
$ git checkout pull/973
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/973/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 973

View PR using the GUI difftool:
$ git pr show -t 973

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/973.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

  • 6ed940b: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • fbfe11f: 8341024: [test] build/AbsPathsInImage.java fails with OOM when using ubsan-enabled binaries
  • f766080: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
  • 8e19c8f: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
  • f9070df: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
  • e5dfeb1: 8342063: [21u][aix] Backport introduced redundant line in ProblemList
  • 62e0147: Merge
  • dfcd8d2: 8341989: [21u] Back out JDK-8327501 and JDK-8328366
  • 0083bcd: 8341674: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.5
  • 90517f5: 8332644: Improve graph optimizations
  • ... and 89 more: https://git.openjdk.org/jdk21u-dev/compare/29b65ab034d40f582505b93f38e0287453b4f796...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e74edbaea9f09169f597a470f647f3b7d10cc71b 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks.

@earthling-amzn
Copy link
Author

/approval request This is a performance enhancement for Shenandoah. It's a clean backport and there are no changes outside of Shenandoah. I do not believe the macos test failure is related to this change.

@openjdk
Copy link

openjdk bot commented Sep 16, 2024

@earthling-amzn
8336640: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 16, 2024
@GoeLin
Copy link
Member

GoeLin commented Sep 17, 2024

Please backport to 23 first.
Removing tag in the meantime

@openjdk openjdk bot removed the approval label Sep 17, 2024
@earthling-amzn
Copy link
Author

/approval request This is a performance enhancement for Shenandoah. It's a clean backport and there are no changes outside of Shenandoah. I do not believe the macos test failure is related to this change. We have been running this change in production for over a month now. This change has also been accepted in jdk23u.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@earthling-amzn
8336640: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Sep 23, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants