Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255466: C2 crashes at ciObject::get_oop() const+0x0 #536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 7, 2024

Hi all,
This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning hotspot/src/share/vm/opto/type.cpp:2556:71: error: ‘this’ pointer is null with gcc13.
Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add bootclasspath.
New test fails without the patch, passes with it.

Additional testing:

  • linux x64 tier1/2/3 jtreg test
  • linux aarch64 tier1/2/3 jtreg test

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8255466 needs maintainer approval

Issue

  • JDK-8255466: C2 crashes at ciObject::get_oop() const+0x0 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/536/head:pull/536
$ git checkout pull/536

Update a local copy of the PR:
$ git checkout pull/536
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 536

View PR using the GUI difftool:
$ git pr show -t 536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/536.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bb3f1238cb12c45ed85936d3b06eced0730d588f 8255466: C2 crashes at ciObject::get_oop() const+0x0 Jul 7, 2024
@openjdk
Copy link

openjdk bot commented Jul 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 7, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2024

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Jul 8, 2024

The GHA report several failures.

  1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3
  1. Linux x86 gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java report crash CompactibleFreeListSpace::block_size(HeapWord const*), which has been recorded by JDK-8303159, it's unrelated to this PR.
  2. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8255466 to fix the corner case in C2. The change has been verified on linux x64 and linux aarch64 with jtreg tier1/2/3.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@sendaoYan
8255466: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 8, 2024
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport includes a backport of JDK-8250825. Please either do that backport first, or merge it with this PR.

@sendaoYan
Copy link
Member Author

This backport includes a backport of JDK-8250825. Please either do that backport first, or merge it with this PR.

Thanks very much for your patience and careful review. I have created a backport PR of JDK-8250825.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Wait the prefixed PR merged.
/approval cancel

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@sendaoYan
8255466: The approval request has been cancelled successfully.

@openjdk openjdk bot removed the approval label Aug 22, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Wait the prefixed #552 merged.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@sendaoYan This pull request is already open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants