8199138: Add RISC-V support to Zero #573

DingliZhang · 2024-09-03T04:42:37Z

Hi all,

I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here.

common/autoconf/build-aux/config.guess and hotspot/src/os/linux/vm/os_linux.cpp do not apply cleanly due to context difference, but it is easy to resolve them manually. common/autoconf/platform.m4 just changed file path and remove test of x$OPENJDK_$1_CPU.

common/autoconf/generated-configure.sh regenerated by bash common/autoconf/autogen.sh. I used autoconf-2.69 and build from the source . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in #413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it!

Both cross-compile build and native build on riscv64 hardware is tested.

cross-compile on x86

boot jdk

openjdk version "1.8.0_43"
OpenJDK Runtime Environment (build 1.8.0_43-b03)
OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode)

run on qemu

openjdk version "1.8.0_432-internal"
OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00)
OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode)

native build on lp4a

boot jdk

openjdk version "1.8.0_412"
OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08)
OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode)

run on lp4a

openjdk version "1.8.0_432-internal"
OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00)
OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode)

Thanks,
Dingli

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8199138 needs maintainer approval

Issue

JDK-8199138: Add RISC-V support to Zero (Bug - P4 - Requested)

Reviewers

Fei Yang (@RealFYang - Committer)

Contributors

Gui Cao <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/573/head:pull/573
$ git checkout pull/573

Update a local copy of the PR:
$ git checkout pull/573
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 573

View PR using the GUI difftool:
$ git pr show -t 573

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/573.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-09-03T04:42:52Z

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-03T04:43:41Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2024-09-03T04:43:54Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-09-03T04:46:43Z

Webrevs

01: Full - Incremental (3cd5a0c1)
00: Full (e35b896f)

DingliZhang · 2024-09-03T05:09:03Z

Thanks to Gui Cao for the original patch.
/contributor add gcao

openjdk · 2024-09-03T05:09:49Z

@DingliZhang
Contributor Gui Cao <[email protected]> successfully added.

DingliZhang · 2024-09-03T06:32:38Z

/approval request allow Zero build on RISC-V

openjdk · 2024-09-03T06:33:34Z

@DingliZhang
8199138: The approval request has been created successfully.

RealFYang

Hi, I have only one minor comment. Thanks.

RealFYang · 2024-09-03T07:29:54Z

hotspot/src/os/linux/vm/os_linux.cpp

@@ -1949,6 +1949,9 @@ void * os::dll_load(const char *filename, char *ebuf, int ebuflen)
  #ifndef EM_AARCH64
  #define EM_AARCH64    183               /* ARM AARCH64 */
  #endif
+  #ifndef EM_RISCV
+  #define EM_RISCV      243               /* RISC-V */
+  #endif


It will be more consistent if you put this after definition of EM_LOONGARCH like you do for the other places.

Thanks for the review! Fixed.

RealFYang

Thanks for the update. I am not sure about the autoconf issue here. You need to ask for the maintainer's comments/suggestions (@gnu-andrew once mentioned the possibility of backporting https://bugs.openjdk.org/browse/JDK-8195689 on #413) to remove the generated configure at the start of the next release cycle). The rest of the change looks good to me (Not a 8u Reviewer).

bridgekeeper · 2024-10-01T12:48:24Z

@DingliZhang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

gnu-andrew · 2024-10-02T16:27:31Z

@DingliZhang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Keep this open. I'll review after the upcoming release on the 15th.

gnu-andrew · 2024-10-02T16:28:25Z

Thanks for the update. I am not sure about the autoconf issue here. You need to ask for the maintainer's comments/suggestions (@gnu-andrew once mentioned the possibility of backporting https://bugs.openjdk.org/browse/JDK-8195689 on #413) to remove the generated configure at the start of the next release cycle). The rest of the change looks good to me (Not a 8u Reviewer).

Yes, the in-tree auto-generated configure is a recurring problem. I certainly would like to backport the other fix. I'll have a look when I review this as to whether we should wait on that here or just commit this as is.

DingliZhang · 2024-10-12T02:59:41Z

Thanks for the update. I am not sure about the autoconf issue here. You need to ask for the maintainer's comments/suggestions (@gnu-andrew once mentioned the possibility of backporting https://bugs.openjdk.org/browse/JDK-8195689 on #413) to remove the generated configure at the start of the next release cycle). The rest of the change looks good to me (Not a 8u Reviewer).

Yes, the in-tree auto-generated configure is a recurring problem. I certainly would like to backport the other fix. I'll have a look when I review this as to whether we should wait on that here or just commit this as is.

Thanks for the reply, I'm looking forward to it.

8199138: Add RISC-V support to Zero

e35b896

openjdk bot changed the title ~~Backport edc4ffe54b8c1f042e98c0ddb9dce757d88b01f4~~ 8199138: Add RISC-V support to Zero Sep 3, 2024

openjdk bot added backport rfr Pull request is ready for review labels Sep 3, 2024

openjdk bot added the approval label Sep 3, 2024

RealFYang suggested changes Sep 3, 2024

View reviewed changes

Put EM_RISCV after definition of EM_LOONGARCH

3cd5a0c

RealFYang approved these changes Sep 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8199138: Add RISC-V support to Zero #573

8199138: Add RISC-V support to Zero #573

DingliZhang commented Sep 3, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 3, 2024

openjdk bot commented Sep 3, 2024

openjdk bot commented Sep 3, 2024

mlbridge bot commented Sep 3, 2024 •

edited

Loading

DingliZhang commented Sep 3, 2024 •

edited

Loading

openjdk bot commented Sep 3, 2024

DingliZhang commented Sep 3, 2024

openjdk bot commented Sep 3, 2024

RealFYang left a comment •

edited

Loading

RealFYang Sep 3, 2024 •

edited

Loading

DingliZhang Sep 3, 2024

RealFYang left a comment •

edited

Loading

bridgekeeper bot commented Oct 1, 2024

gnu-andrew commented Oct 2, 2024

gnu-andrew commented Oct 2, 2024

DingliZhang commented Oct 12, 2024

8199138: Add RISC-V support to Zero #573

Are you sure you want to change the base?

8199138: Add RISC-V support to Zero #573

Conversation

DingliZhang commented Sep 3, 2024 • edited by openjdk bot Loading

cross-compile on x86

boot jdk

run on qemu

native build on lp4a

boot jdk

run on lp4a

Progress

Issue

Reviewers

Contributors

Reviewing

Webrev

bridgekeeper bot commented Sep 3, 2024

openjdk bot commented Sep 3, 2024

openjdk bot commented Sep 3, 2024

mlbridge bot commented Sep 3, 2024 • edited Loading

Webrevs

DingliZhang commented Sep 3, 2024 • edited Loading

openjdk bot commented Sep 3, 2024

DingliZhang commented Sep 3, 2024

openjdk bot commented Sep 3, 2024

RealFYang left a comment • edited Loading

Choose a reason for hiding this comment

RealFYang Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

DingliZhang Sep 3, 2024

Choose a reason for hiding this comment

RealFYang left a comment • edited Loading

Choose a reason for hiding this comment

bridgekeeper bot commented Oct 1, 2024

gnu-andrew commented Oct 2, 2024

gnu-andrew commented Oct 2, 2024

DingliZhang commented Oct 12, 2024

DingliZhang commented Sep 3, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 3, 2024 •

edited

Loading

DingliZhang commented Sep 3, 2024 •

edited

Loading

RealFYang left a comment •

edited

Loading

RealFYang Sep 3, 2024 •

edited

Loading

RealFYang left a comment •

edited

Loading