-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unnecessary logical conditions #579
base: master
Are you sure you want to change the base?
Conversation
Hi @tobemonkey, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tobemonkey" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Hi, please send me an e-mail at [email protected] so that I can verify your account. |
@tobemonkey I cannot comment on the change itself, but this condition does not seem specific to 8 and is also present in newest jdk. Changes should generally go to newest jdk (unless it is something specific to old jdk). Then it can backported (gradually from newest to oldest), if desired. |
Alright, I know this small change might seem insignificant, but after thinking it over, I’ve decided to submit my code and hope it gets accepted
Progress
Error
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/579/head:pull/579
$ git checkout pull/579
Update a local copy of the PR:
$ git checkout pull/579
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/579/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 579
View PR using the GUI difftool:
$ git pr show -t 579
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/579.diff