Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349105: Pagination: exception initializing in a background thread #1698

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -126,16 +126,12 @@ public class PaginationSkin extends SkinBase<Pagination> {
private boolean nextPageReached = false;
private boolean setInitialDirection = false;
private int direction;

private int currentAnimatedIndex;
private boolean hasPendingAnimation = false;

private volatile boolean hasPendingAnimation;
private boolean animate = true;

private final PaginationBehavior behavior;



/* *************************************************************************
* *
* Listeners *
Expand Down Expand Up @@ -706,6 +702,10 @@ private int getCurrentPageIndex() {
}

private void animateSwitchPage() {
if (!Platform.isFxApplicationThread()) {
hasPendingAnimation = true;
return;
}
if (timeline != null) {
timeline.setRate(8);
hasPendingAnimation = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,6 @@ public void menuButton() {
});
}

@Disabled("JDK-8349105") // FIX
@Test
public void pagination() {
assumeFalse(SKIP_TEST);
Expand Down