8348095: [Linux] Menu shows up in wrong position when using i3 windows manager in full screen mode

[tsayao]

The issue was with the view's position, specifically the content's X and Y coordinates relative to the window, including its decorations. When in fullscreen mode, the window remains decorated, but the decorations are hidden. As a result, the content's position needs to be recalculated to account for the window's adjusted layout.

It's not specific to i3.

I used gdk_window_get_root_origin because GTK provides a more robust mechanism to determine the value, even in cases where _NET_FRAME_EXTENTS is not supported by the window manager.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8348095: [Linux] Menu shows up in wrong position when using i3 windows manager in full screen mode (Bug - P4)

Reviewers

• Jose Pereda (@jperedadnr - Reviewer)
• Lukasz Kostyra (@lukostyra - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1702/head:pull/1702
$ git checkout pull/1702

Update a local copy of the PR:
$ git checkout pull/1702
$ git pull https://git.openjdk.org/jfx.git pull/1702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1702

View PR using the GUI difftool:
$ git pr show -t 1702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1702.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tsayao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tsayao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348095: [Linux] Menu shows up in wrong position when using i3 windows manager in full screen mode

Reviewed-by: jpereda, lkostyra

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 03: Full - Incremental (c2b56ab6)
• 02: Full - Incremental (bd12ebca)
• 01: Full - Incremental (ac68cfb3)
• 00: Full (b3443aef)

[jperedadnr]

I've tested successfully on Ubuntu, with or without i3 wm, and Fedora+Sway.
It looks good, but I had to add some debug info myself for better understanding of the changes... so that's why I left one remark.

[tsayao]

I tested it on Ubuntu 24.04 with Xorg / Wayland (Gnome) and Xorg / Kde.
Did a complete unit test run on 20.04 / Xorg (Gnome) with one unrelated failure.

[jperedadnr]

Looks good!

[kevinrushforth]

@lukostyra Can you also review?

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[lukostyra]

Can you merge the latest master? Web tests are failing on my end but I suspect it's because of WebKit upgrade that just happened (latest master works fine and this branch does not have it)

[lukostyra]

Everything works fine now. LGTM

[tsayao]

/integrate

[openjdk]

Going to push as commit b267340.

[openjdk]

@tsayao Pushed as commit b267340.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.