Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903081: Update asmtools and remove jcov traces #228

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Sep 24, 2024

work in progress...

Blocked by AsmTools requiring JDK 17 (or above) to be built: https://github.com/openjdk/asmtools/blob/7ea57726a181b819c4b6331b19160c4fce238b11/build/build.properties#L30-L31


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.org/jtreg.git pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/228.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2024

@sormuras This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2025

@sormuras This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 14, 2025
@sormuras
Copy link
Member Author

sormuras commented Feb 5, 2025

/open

@openjdk openjdk bot reopened this Feb 5, 2025
@openjdk
Copy link

openjdk bot commented Feb 5, 2025

@sormuras This pull request is now open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant