Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903935: --verify-exclude existence check misses tests with failing requires #243

Closed
wants to merge 2 commits into from
Closed

7903935: --verify-exclude existence check misses tests with failing requires #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f042d77
7903935 --verify-exclude existence check misses tests with failing re…
LudwikJaniuk Jan 21, 2025
3131c35
Update comment
LudwikJaniuk Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/share/classes/com/sun/javatest/regtest/tool/Tool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,7 +1439,7 @@ void verifyExcludeLists(TestManager testManager, Path baseDir) throws BadArgs, F
}

RegressionParameters params = createParameters(dummyTestManager, ts);
for (Iterator<TestResult> iter = getResultsIterator(params); iter.hasNext(); ) {
for (Iterator<TestResult> iter = getEagerResultsIterator(params); iter.hasNext(); ) {
TestResult tr = iter.next();
validTestNames.add(tr.getTestName());
if (verbose == Verbose.ALL) {
Expand Down Expand Up @@ -2208,6 +2208,15 @@ else if (tests.length == 0)
return trt.getIterator(tests, filters);
}

// An iterator that applies no filters.
// The intention is to help discover all "existing" tests.
private Iterator<TestResult> getEagerResultsIterator(InterviewParameters params) {
TestResultTable trt = params.getWorkDirectory().getTestResultTable();
trt.waitUntilReady();
TestFilter[] filters = null;
return trt.getIterator(filters);
}

private void showTool(final InterviewParameters params) throws BadArgs {
EventQueue.invokeLater(new Runnable() {
@Override
Expand Down