-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix miss makezero bug #1628
Conversation
Signed-off-by: alingse <[email protected]>
Welcome @alingse! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1628 +/- ##
==========================================
+ Coverage 47.91% 49.04% +1.12%
==========================================
Files 162 180 +18
Lines 23491 18803 -4688
==========================================
- Hits 11256 9221 -2035
+ Misses 11014 8371 -2643
+ Partials 1221 1211 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: alingse <[email protected]>
Ⅰ. Describe what this PR does
I was running github actions to run linter makezero for top github golang repos.
see issues alingse/go-linter-runner#1
and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242658768/job/25425757534
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
the names no need empty string value
Ⅳ. Special notes for reviews