Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handleDeployment warn log #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jingliming
Copy link

Ⅰ. Describe what this PR does

handleDeployment function missed warning log

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Special notes for reviews

add handleDeployment warn log

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @jingliming! It looks like this is your first PR to openkruise/rollouts 🎉

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 45.44%. Comparing base (76d33b8) to head (d9d5dc8).
Report is 16 commits behind head on master.

Files Patch % Lines
...bhook/workload/mutating/workload_update_handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   43.87%   45.44%   +1.56%     
==========================================
  Files          50       52       +2     
  Lines        5374     6518    +1144     
==========================================
+ Hits         2358     2962     +604     
- Misses       2618     3068     +450     
- Partials      398      488      +90     
Flag Coverage Δ
unittests 45.44% <0.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg zmberg closed this Apr 2, 2024
@zmberg zmberg reopened this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants